From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A788F90DED for ; Thu, 25 Jan 2024 15:42:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 898241B960 for ; Thu, 25 Jan 2024 15:41:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 25 Jan 2024 15:41:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B0E59492A3 for ; Thu, 25 Jan 2024 15:41:54 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 25 Jan 2024 15:41:45 +0100 Message-Id: <20240125144149.216064-10-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240125144149.216064-1-f.ebner@proxmox.com> References: <20240125144149.216064-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC guest-common 09/13] vzdump: schema: add fleecing property string X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2024 14:42:25 -0000 It's a property string, because that avoids having an implicit "enabled" as part of a 'fleecing-storage' property. And there likely will be more options in the future, e.g. threshold/limit for the fleecing image size. Signed-off-by: Fiona Ebner --- src/PVE/VZDump/Common.pm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 5be87a0..60574e4 100644 --- a/src/PVE/VZDump/Common.pm +++ b/src/PVE/VZDump/Common.pm @@ -33,6 +33,7 @@ my $dowhash_to_dow = sub { }; our $PROPERTY_STRINGS = { + 'fleecing' => 'backup-fleecing', 'performance' => 'backup-performance', 'prune-backups' => 'prune-backups', }; @@ -79,6 +80,24 @@ sub parse_dow { return $res; }; +PVE::JSONSchema::register_format('backup-fleecing', { + enabled => { + description => "Enable backup fleecing. Cache backup data from blocks where new guest " + ."writes happen on specified storage instead of copying them directly to the backup " + ."target. This can help guest IO performance and even prevent hangs, at the cost of " + ."requiring more storage space.", + type => 'boolean', + default => 0, + optional => 1, + default_key => 1, + }, + storage => get_standard_option('pve-storage-id', { + description => "Use this storage to storage fleecing images. Default is to use the same " + ."storage as the VM disk itself.", + optional => 1, + }), +}); + PVE::JSONSchema::register_format('backup-performance', { 'max-workers' => { description => "Applies to VMs. Allow up to this many IO workers at the same time.", @@ -262,6 +281,12 @@ my $confdesc = { format => 'backup-performance', optional => 1, }, + fleecing => { + type => 'string', + description => "Options for backup fleecing (VM only).", + format => 'backup-fleecing', + optional => 1, + }, lockwait => { type => 'integer', description => "Maximal time to wait for the global lock (minutes).", -- 2.39.2