From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0538DC22CC for ; Mon, 22 Jan 2024 10:55:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D582218FCA for ; Mon, 22 Jan 2024 10:55:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 22 Jan 2024 10:55:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E88314659B for ; Mon, 22 Jan 2024 10:55:24 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 22 Jan 2024 10:55:21 +0100 Message-Id: <20240122095521.23260-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vzdump.pm] Subject: [pve-devel] [PATCH manager] vzdump: also warn when hook script fails for backup-abort or log-end phase X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2024 09:55:26 -0000 to make it more visible, also in task logs. Signed-off-by: Fiona Ebner --- PVE/VZDump.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 4185ed62..98641f5a 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1269,6 +1269,7 @@ sub exec_backup_task { debugmsg ('info', "Failed at " . strftime("%F %H:%M:%S", localtime())); eval { $self->run_hook_script ('backup-abort', $task, $logfd); }; + debugmsg('warn', $@) if $@; # message already contains command with phase name } else { $task->{state} = 'ok'; @@ -1300,6 +1301,7 @@ sub exec_backup_task { } eval { $self->run_hook_script ('log-end', $task); }; + debugmsg('warn', $@) if $@; # message already contains command with phase name die $err if $err && $err =~ m/^interrupted by signal$/; } -- 2.39.2