From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4AA44C1C9E for ; Thu, 18 Jan 2024 12:12:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2923A14378 for ; Thu, 18 Jan 2024 12:12:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 18 Jan 2024 12:12:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 73D59491A0 for ; Thu, 18 Jan 2024 12:12:32 +0100 (CET) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Thu, 18 Jan 2024 12:11:47 +0100 Message-Id: <20240118111147.131727-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm, sourceware.org, proxmox.com] Subject: [pve-devel] [PATCH v2 storage] lvm: improve warning in case vgs output contains unexpected lines X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2024 11:12:34 -0000 If the metadata archive under /etc/lvm/archive for a particular VG has a lot of files or is overly large, `vgs` occasionally prints a message to stdout [1]. Currently, the LVM plugin tries to parse this message and thus produces the following confusing warnings in the output of `pvesm status` or the journal (via pvestatd): Use of uninitialized value $size in int at [...]/LVMPlugin.pm line 133 Use of uninitialized value $free in int at [...]/LVMPlugin.pm line 133 Use of uninitialized value $lvcount in int [...]/LVMPlugin.pm line 133 Reported in enterprise support where LVM picked up on VGs on VM disks (due to a missing KRBD device filter in the LVM config), and since several VM disks had VGs with the same name, LVM quickly produced a lot of files in /etc/lvm/archive. Reproducible as follows with a VG named `spam`: for i in $(seq 8192); do vgrename spam spam2; vgrename spam2 spam; done rm /etc/lvm/backup/spam; vgs -o vg_name Output (linebreak for readability): Consider pruning spam VG archive with more then 8 MiB in 8268\n files (check archiving is needed in lvm.conf). VG spam With this patch, the LVM plugin instead prints a human-readable warning about the unexpected line. [1] https://sourceware.org/git/?p=lvm2.git;a=blob;f=lib/format_text/archive.c;h=5acf0c04a;hb=38e0c7a1#l222 Signed-off-by: Friedrich Weber --- Notes: changes from v1 [2]: * warn about the unexpected line instead of simply ignoring it [2] https://lists.proxmox.com/pipermail/pve-devel/2024-January/061333.html src/PVE/Storage/LVMPlugin.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm index 4b951e7..5377823 100644 --- a/src/PVE/Storage/LVMPlugin.pm +++ b/src/PVE/Storage/LVMPlugin.pm @@ -130,6 +130,11 @@ sub lvm_vgs { my ($name, $size, $free, $lvcount, $pvname, $pvsize, $pvfree) = split (':', $line); + if (!defined($size) || !defined($free) || !defined($lvcount)) { + warn "unexpected output from vgs: $line\n"; + return; + } + $vgs->{$name} //= { size => int ($size), free => int ($free), -- 2.39.2