From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B8D4C0378 for ; Wed, 10 Jan 2024 13:46:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 62D6C33571 for ; Wed, 10 Jan 2024 13:46:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 10 Jan 2024 13:46:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 216D049042 for ; Wed, 10 Jan 2024 13:46:13 +0100 (CET) From: Hannes Duerr To: pve-devel@lists.proxmox.com Date: Wed, 10 Jan 2024 13:45:48 +0100 Message-Id: <20240110124549.160682-1-h.duerr@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.pm, qemu.pm, qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server v7 0/1] fix #4957: add vendor and product information passthrough for SCSI-Disks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2024 12:46:14 -0000 changes in v2: - when calling the API to create/update a VM, check whether the devices are "scsi-hd" or "scsi-cd" devices,where there is the option to add vendor and product information, if not error out - change the format in product_fmt and vendor_fmt to a pattern that only allows 40 characters consisting of upper and lower case letters, numbers and '-' and '_'. changes in v3: - splitup into preparation and fix patch - move get_scsi_devicetype into QemuServer/Drive.pm - refactor check_scsi_feature_compatibility to assert_scsi_feature_compatibility - assert_scsi_feature_compatibility before creating the device - handle 'local-lvm:' syntax in get_scsi_devicetype - fix style issues changes in v4: - create assert_scsi_feature_compatibility() in API2/Qemu.pm - divide the preparation into smaller steps - remove or harden brittle regex - fix wrong storagename assumption changes in v5: - fix copy/paste mistake changes in v6: - add whitespace to allowed characters for vendor and product information - fix undefined subroutine errors - fix nits changes in v7: - use PVE::QemuServer::Machine::extract_version() to avoid making the helper public - since the properties cannot be hotplugged, skip the properties during hotplugg - reduce the amount of allowed characters due to restrictions in qemu qemu-server: Hannes Duerr (1): fix #4957: add vendor and product information passthrough for SCSI-Disks PVE/API2/Qemu.pm | 39 +++++++++++++++++++++++++++++++++++++++ PVE/QemuServer.pm | 12 ++++++++++++ PVE/QemuServer/Drive.pm | 24 ++++++++++++++++++++++++ 3 files changed, 75 insertions(+) Summary over all repositories: 3 files changed, 75 insertions(+), 0 deletions(-) -- Generated by git-murpp 0.5.0