From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31C7ABC2E5 for ; Fri, 22 Dec 2023 11:52:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13188452D for ; Fri, 22 Dec 2023 11:52:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Dec 2023 11:52:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 479AC43580 for ; Fri, 22 Dec 2023 11:52:49 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Fri, 22 Dec 2023 11:52:24 +0100 Message-ID: <20231222105244.715015-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [options.rs, github.io] Subject: [pve-devel] [RFC PATCH installer] proxinstall, common: remove deprecated fletcher2 as zfs checksum algorithm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2023 10:52:51 -0000 Fletcher-2 has long been deprecated and should not be used anymore [0][1], so we probably should not offer it anymore too. It's been deprecated since at least over 3 years, beyond that it's hard to find an exact date. Signed-off-by: Christoph Heiss [0] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#checksum-algorithms [1] https://people.freebsd.org/~asomers/fletcher.pdf --- Sending this as RFC since it might warrant some discussions. While digging into this a bit more, I reckon we should remove 'off' as an option too. It's considered an "extraordinarily bad idea" [2] (for to pretty obvious reason) and nobody should ever use it. Might be a good idea, just so that users simply disable checksum "for performance reasons" without knowing about the implications of this. [2] https://openzfs.github.io/openzfs-docs/Basic%20Concepts/Checksums.html#disabling-checksums proxinstall | 2 +- proxmox-installer-common/src/options.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/proxinstall b/proxinstall index 01d4cfe..d6d5acb 100755 --- a/proxinstall +++ b/proxinstall @@ -1145,7 +1145,7 @@ my $create_raid_advanced_grid = sub { my $combo_checksum = Gtk3::ComboBoxText->new(); $combo_checksum->set_tooltip_text("zfs checksum algorithm for rpool dataset"); - my $csum_opts = ["on", "off","fletcher2", "fletcher4", "sha256"]; + my $csum_opts = ["on", "off", "fletcher4", "sha256"]; foreach my $opt (@$csum_opts) { $combo_checksum->append($opt, $opt); } diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs index afd12cd..98cd907 100644 --- a/proxmox-installer-common/src/options.rs +++ b/proxmox-installer-common/src/options.rs @@ -146,7 +146,6 @@ pub enum ZfsChecksumOption { #[default] On, Off, - Fletcher2, Fletcher4, Sha256, } @@ -165,7 +164,7 @@ impl From<&ZfsChecksumOption> for String { pub const ZFS_CHECKSUM_OPTIONS: &[ZfsChecksumOption] = { use ZfsChecksumOption::*; - &[On, Off, Fletcher2, Fletcher4, Sha256] + &[On, Off, Fletcher4, Sha256] }; #[derive(Clone, Debug)] -- 2.42.0