From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A63EEBC0A2 for ; Thu, 21 Dec 2023 10:53:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EC8C17298 for ; Thu, 21 Dec 2023 10:53:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Dec 2023 10:53:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C1F6948A53 for ; Thu, 21 Dec 2023 10:53:17 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 21 Dec 2023 10:53:11 +0100 Message-Id: <20231221095313.156390-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sshinfo.pm, setup.pm] Subject: [pve-devel] [RFC cluster 0/2] fix #4886: improve SSH handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2023 09:53:18 -0000 RFC since this would be a bigger change in how we approach intra-cluster SSH access. there are still a few parts that currently don't use SSHInfo, but would need to be switched over if we want to pursue this approach: - get_vnc_connection_info in PVE::API2::Nodes - 'upload' API endpoint in PVE::API2::Storage::Status - SSH proxy in pvesh these changes would need to happen coordinated with the patches from this RFC series! next steps afterwards: - unmerge known hosts in `pvecm updatecerts`, instead of merging -- to disentangle regular ssh from intra-cluster SSH -- to allow `ssh-keygen -f .. -R ..` to work properly again -- existing keys would still be preserved for not-yet-upgraded nodes, so this should be do-able without waiting for a major release.. - evaluate whether we want to split out -- the client config (we currently force a cipher order there) -- the client key (could live in /etc/pve/priv instead?) -- or even the sshd instance altogether (would allow not touching the regular sshd config at all) Fabian Grünbichler (2): fix #4886: write node SSH hostkey to pmxcfs fix #4886: SSH: pin node's host key if available src/PVE/Cluster/Setup.pm | 15 +++++++++++++++ src/PVE/SSHInfo.pm | 15 ++++++++++++++- 2 files changed, 29 insertions(+), 1 deletion(-) -- 2.39.2