From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3368CBA859 for ; Thu, 14 Dec 2023 17:47:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 165691A019 for ; Thu, 14 Dec 2023 17:46:50 +0100 (CET) Received: from lana.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Thu, 14 Dec 2023 17:46:49 +0100 (CET) Received: by lana.proxmox.com (Postfix, from userid 10043) id 455F12C0767; Thu, 14 Dec 2023 17:46:49 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 14 Dec 2023 17:46:46 +0100 Message-Id: <20231214164647.435079-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231214164647.435079-1-s.hanreich@proxmox.com> References: <20231214164647.435079-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.414 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH pve-network 2/3] zones: add method for getting MTU X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 16:47:20 -0000 Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Zones.pm | 8 ++++++++ src/PVE/Network/SDN/Zones/Plugin.pm | 7 +++++++ src/PVE/Network/SDN/Zones/SimplePlugin.pm | 8 +++++++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/PVE/Network/SDN/Zones.pm b/src/PVE/Network/SDN/Zones.pm index 5bd3536..c1c7745 100644 --- a/src/PVE/Network/SDN/Zones.pm +++ b/src/PVE/Network/SDN/Zones.pm @@ -27,6 +27,7 @@ PVE::Network::SDN::Zones::SimplePlugin->register(); PVE::Network::SDN::Zones::Plugin->init(); my $local_network_sdn_file = "/etc/network/interfaces.d/sdn"; +my $default_mtu = 1500; sub sdn_zones_config { my ($cfg, $id, $noerr) = @_; @@ -369,5 +370,12 @@ sub del_bridge_fdb { $plugin->del_bridge_fdb($plugin_config, $iface, $macaddr); } +sub get_mtu { + my ($zone_config) = @_; + + my $plugin = PVE::Network::SDN::Zones::Plugin->lookup($zone_config->{type}); + return $plugin->get_mtu($zone_config) // $default_mtu; +} + 1; diff --git a/src/PVE/Network/SDN/Zones/Plugin.pm b/src/PVE/Network/SDN/Zones/Plugin.pm index b55b967..c1f95fc 100644 --- a/src/PVE/Network/SDN/Zones/Plugin.pm +++ b/src/PVE/Network/SDN/Zones/Plugin.pm @@ -356,4 +356,11 @@ sub get_bridge_ifaces { return @bridge_ifaces; } + +sub get_mtu { + my ($class, $plugin_config) = @_; + + die "please implement inside plugin"; +} + 1; diff --git a/src/PVE/Network/SDN/Zones/SimplePlugin.pm b/src/PVE/Network/SDN/Zones/SimplePlugin.pm index c996bf3..9540449 100644 --- a/src/PVE/Network/SDN/Zones/SimplePlugin.pm +++ b/src/PVE/Network/SDN/Zones/SimplePlugin.pm @@ -56,7 +56,7 @@ sub generate_sdn_config { my $mac = $vnet->{mac}; my $alias = $vnet->{alias}; - my $mtu = $plugin_config->{mtu} if $plugin_config->{mtu}; + my $mtu = $class->get_mtu($plugin_config); # vnet bridge my @iface_config = (); @@ -144,6 +144,12 @@ sub vnet_update_hook { } } +sub get_mtu { + my ($class, $plugin_config) = @_; + + return $plugin_config->{mtu}; +} + 1; -- 2.39.2