From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1D06BBA762 for ; Thu, 14 Dec 2023 15:12:02 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E905417BA7 for ; Thu, 14 Dec 2023 15:12:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Dec 2023 15:12:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EFAD64761B for ; Thu, 14 Dec 2023 15:12:00 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Thu, 14 Dec 2023 15:11:54 +0100 Message-Id: <20231214141154.279100-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231214141154.279100-1-l.wagner@proxmox.com> References: <20231214141154.279100-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/2] vzdump: make helper functions for sending notifications private X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 14:12:02 -0000 The helpers were split out from the original 'sendmail' function when migrating to the new notification system. They are not needed anywhere else and can thus be private. Signed-off-by: Lukas Wagner --- PVE/VZDump.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 91f60418..009eb369 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -318,7 +318,7 @@ sub read_vzdump_defaults { return $res; } -sub read_backup_task_logs { +my sub read_backup_task_logs { my ($task_list) = @_; my $task_logs = ""; @@ -345,7 +345,7 @@ sub read_backup_task_logs { return $task_logs; } -sub build_guest_table { +my sub build_guest_table { my ($task_list) = @_; my $table = { @@ -399,7 +399,7 @@ sub build_guest_table { return $table; } -sub sanitize_task_list { +my sub sanitize_task_list { my ($task_list) = @_; for my $task (@$task_list) { chomp $task->{msg} if $task->{msg}; @@ -427,7 +427,7 @@ my sub aggregate_task_statistics { return $error_count, $total_size; } -sub get_hostname { +my sub get_hostname { my $hostname = `hostname -f` || PVE::INotify::nodename(); chomp $hostname; return $hostname; -- 2.39.2