From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7EEBBBA0A2 for ; Wed, 13 Dec 2023 15:18:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 50682B124 for ; Wed, 13 Dec 2023 15:17:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Dec 2023 15:17:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7019047136 for ; Wed, 13 Dec 2023 15:17:50 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 13 Dec 2023 15:17:47 +0100 Message-Id: <20231213141747.679613-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231213141747.679613-1-f.ebner@proxmox.com> References: <20231213141747.679613-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, abstractconfig.pm] Subject: [pve-devel] [PATCH v2 guest-common 3/3] abstract config: fix snapshot needed by replication check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2023 14:18:22 -0000 Do not pass the cleanup flag to get_replicatable_volumes() which leads to replicatable volumes that have the replicate setting turned off to be part of the result. Instead pass the noerr flag, because things like missing the storage-level replicate feature should not lead to an error here. Reported in the community forum: https://forum.proxmox.com/threads/120910/post-605574 Signed-off-by: Fiona Ebner --- New in v2. src/PVE/AbstractConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index a286b13..5d5f9b4 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -862,7 +862,7 @@ my $snapshot_delete_assert_not_needed_by_replication = sub { my $storecfg = PVE::Storage::config(); # Current config's volumes are relevant for replication. - my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 1); + my $volumes = $class->get_replicatable_volumes($storecfg, $vmid, $conf, 0, 1); my $replication_jobs = $repl_conf->list_guests_local_replication_jobs($vmid); -- 2.39.2