From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 79B0ABA099 for ; Wed, 13 Dec 2023 15:18:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5903DB1AE for ; Wed, 13 Dec 2023 15:17:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Dec 2023 15:17:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1F57C47132 for ; Wed, 13 Dec 2023 15:17:50 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 13 Dec 2023 15:17:45 +0100 Message-Id: <20231213141747.679613-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231213141747.679613-1-f.ebner@proxmox.com> References: <20231213141747.679613-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replication.pm] Subject: [pve-devel] [PATCH v2 guest-common 1/3] replication: prepare: include volumes without snapshots in the result X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2023 14:18:21 -0000 Note that PVE::Storage::volume_snapshot_info() will fail when a volume does not exist, so no non-existing volume will end up in the result (prepare() is only called with volumes that should exist). This makes it possible to detect a volume without snapshots in the result of prepare(), and as a consequence, replication will now also fail early in a situation where source and remote volume both exist, but (at least) one of them doesn't have any snapshots. Such a situation can happen, for example, by deleting and re-creating a volume with the same name on the source side without running replication after deletion. Signed-off-by: Fiona Ebner --- No changes in v2. src/PVE/Replication.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index bd627e5..05c2632 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -172,6 +172,8 @@ sub prepare { my $local_snapshots = {}; my $cleaned_replicated_volumes = {}; foreach my $volid (@$volids) { + $local_snapshots->{$volid} = {}; + my $info = PVE::Storage::volume_snapshot_info($storecfg, $volid); my $removal_ok = !defined($snapname) || $info->{$snapname}; -- 2.39.2