From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 1831BB9D7F
for <pve-devel@lists.proxmox.com>; Tue, 12 Dec 2023 14:43:10 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E666735617
for <pve-devel@lists.proxmox.com>; Tue, 12 Dec 2023 14:42:39 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 12 Dec 2023 14:42:39 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EE69946036
for <pve-devel@lists.proxmox.com>; Tue, 12 Dec 2023 14:42:38 +0100 (CET)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Tue, 12 Dec 2023 14:42:35 +0100
Message-Id: <20231212134235.659521-1-f.ebner@proxmox.com>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.077 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: [pve-devel] [PATCH qemu] fix #4507: add patch to automatically
increase NOFILE soft limit
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 12 Dec 2023 13:43:10 -0000
In many configurations, e.g. multiple vNICs with multiple queues or
with many Ceph OSDs, the default soft limit of 1024 is not enough.
QEMU is supposed to work fine with file descriptors >= 1024 and does
not use select() on POSIX. Bump the soft limit to the allowed hard
limit to avoid issues with the aforementioned configurations.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
...-increase-NOFILE-soft-limit-on-POSIX.patch | 97 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 98 insertions(+)
create mode 100644 debian/patches/pve/0047-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch
diff --git a/debian/patches/pve/0047-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch b/debian/patches/pve/0047-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch
new file mode 100644
index 0000000..2ee0676
--- /dev/null
+++ b/debian/patches/pve/0047-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch
@@ -0,0 +1,97 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Fiona Ebner <f.ebner@proxmox.com>
+Date: Tue, 12 Dec 2023 14:27:43 +0100
+Subject: [PATCH] qemu_init: increase NOFILE soft limit on POSIX
+
+In many configurations, e.g. multiple vNICs with multiple queues or
+with many Ceph OSDs, the default soft limit of 1024 is not enough.
+QEMU is supposed to work fine with file descriptors >= 1024 and does
+not use select() on POSIX. Bump the soft limit to the allowed hard
+limit to avoid issues with the aforementioned configurations.
+
+Buglink: https://bugzilla.proxmox.com/show_bug.cgi?id=4507
+Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
+---
+ include/sysemu/os-posix.h | 1 +
+ include/sysemu/os-win32.h | 5 +++++
+ os-posix.c | 18 ++++++++++++++++++
+ softmmu/vl.c | 2 ++
+ 4 files changed, 26 insertions(+)
+
+diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
+index 1030d39904..edc415aff5 100644
+--- a/include/sysemu/os-posix.h
++++ b/include/sysemu/os-posix.h
+@@ -48,6 +48,7 @@ void os_setup_early_signal_handling(void);
+ void os_set_proc_name(const char *s);
+ void os_setup_signal_handling(void);
+ void os_daemonize(void);
++void os_setup_limits(void);
+ void os_setup_post(void);
+ int os_mlock(void);
+
+diff --git a/include/sysemu/os-win32.h b/include/sysemu/os-win32.h
+index 91aa0d7ec0..f6e23fe01e 100644
+--- a/include/sysemu/os-win32.h
++++ b/include/sysemu/os-win32.h
+@@ -129,6 +129,11 @@ static inline int os_mlock(void)
+ return -ENOSYS;
+ }
+
++void os_setup_limits(void)
++{
++ return;
++}
++
+ #define fsync _commit
+
+ #if !defined(lseek)
+diff --git a/os-posix.c b/os-posix.c
+index fb2ad87009..9f8261320e 100644
+--- a/os-posix.c
++++ b/os-posix.c
+@@ -24,6 +24,7 @@
+ */
+
+ #include "qemu/osdep.h"
++#include <sys/resource.h>
+ #include <sys/wait.h>
+ #include <pwd.h>
+ #include <grp.h>
+@@ -288,6 +289,23 @@ void os_daemonize(void)
+ }
+ }
+
++void os_setup_limits(void)
++{
++ struct rlimit nofile;
++
++ if (getrlimit(RLIMIT_NOFILE, &nofile) < 0) {
++ warn_report("unable to query NOFILE limit: %s", strerror(errno));
++ return;
++ }
++
++ nofile.rlim_cur = nofile.rlim_max;
++
++ if (setrlimit(RLIMIT_NOFILE, &nofile) < 0) {
++ warn_report("unable to set NOFILE limit: %s", strerror(errno));
++ return;
++ }
++}
++
+ void os_setup_post(void)
+ {
+ int fd = 0;
+diff --git a/softmmu/vl.c b/softmmu/vl.c
+index 20ba2c5c87..fde2be6893 100644
+--- a/softmmu/vl.c
++++ b/softmmu/vl.c
+@@ -2723,6 +2723,8 @@ void qemu_init(int argc, char **argv)
+ error_init(argv[0]);
+ qemu_init_exec_dir(argv[0]);
+
++ os_setup_limits();
++
+ qemu_init_arch_modules();
+
+ qemu_init_subsystems();
diff --git a/debian/patches/series b/debian/patches/series
index 7dcedcb..b19d81a 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -61,3 +61,4 @@ pve/0043-alloc-track-fix-deadlock-during-drop.patch
pve/0044-migration-for-snapshots-hold-the-BQL-during-setup-ca.patch
pve/0045-savevm-async-don-t-hold-BQL-during-setup.patch
pve/0046-virtio-blk-scsi-work-around-iothread-polling-getting.patch
+pve/0047-qemu_init-increase-NOFILE-soft-limit-on-POSIX.patch
--
2.39.2