From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C4D8B9A22 for ; Mon, 11 Dec 2023 15:48:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6553719744 for ; Mon, 11 Dec 2023 15:48:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Dec 2023 15:48:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CD72D45B4C for ; Mon, 11 Dec 2023 15:48:12 +0100 (CET) From: Folke Gleumes To: pve-devel@lists.proxmox.com Date: Mon, 11 Dec 2023 15:47:17 +0100 Message-Id: <20231211144721.212071-1-f.gleumes@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC cluster/common/widget-toolkit/manager 0/4] split node memory graph into usage types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2023 14:48:47 -0000 The goal of this patchseries is to make it more intuitive to understand the memory usage of an instance by splitting the memory usage graph into 'Used', 'Buffer/Cache', 'ZFS Arc' and 'Free' instead of 'Total' and 'RAM usage', displayed as different colored segments in a stacking graph that adds up to the total memory. Previously, the zfs arc counted towards the used memory, which could give a skewed perspective, since there is no visual difference between almost all memory being used with next to no arc or half of the memory used with a big arc. Since there has already been a heated discussion on Bugzilla [0] on what to display, I thought I would post this as an RFC before I finish up the patchseries. Another question would be if other places that display the memory usage should also be split, i.e. the progress bar and gauge chart in the cluster overview. Previously they included the zfs arc, with this series the arc is not counted as used memory, since it technically can be freed (with some caveats). Unfortunately, there is a visual inconsistency with the way that missing data is displayed in the new graph, since it seems impossible to display missing data as a gap when using an area graph, which is possible and the default in the line graph that is used throughout the rest of the ui. Note that applying this patch will currently reset your metrics, so you'll have to wait a bit to see results. [0] https://bugzilla.proxmox.com/show_bug.cgi?id=1454 cluster: Folke Gleumes (1): rrd: add free, buffer/cache and arc size to memory statistics src/pmxcfs/status.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) common: Folke Gleumes (1): add more detailed statistics to memory report src/PVE/ProcFSTools.pm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) widget-toolkit: Folke Gleumes (1): add option to display rrd graph as stacking src/panel/RRDChart.js | 59 +++++++++++++++++++++++++++++++++---------- 1 file changed, 46 insertions(+), 13 deletions(-) manager: Folke Gleumes (1): split ram usage into usage types PVE/API2/Nodes.pm | 6 +++--- PVE/API2Tools.pm | 2 +- PVE/Service/pvestatd.pm | 15 +++++++++++---- www/manager6/node/Summary.js | 6 ++++-- 4 files changed, 19 insertions(+), 10 deletions(-) -- 2.39.2