From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E07FFB8FF0 for ; Thu, 7 Dec 2023 14:35:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C08F01113B for ; Thu, 7 Dec 2023 14:35:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Dec 2023 14:35:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E92AF43499 for ; Thu, 7 Dec 2023 14:35:58 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 7 Dec 2023 14:35:58 +0100 Message-Id: <20231207133558.566788-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2023 13:35:59 -0000 with this the title is now completely visible when the column is expanded, even if it's originally too narrow. Suggested-by: Thomas Lamprecht Signed-off-by: Dominik Csapak --- changes from v1: * wrap the text in the column, instead of duplicating it in the expanded body thanks @thomas for the suggestion www/css/ext6-pve.css | 4 ++++ www/manager6/ceph/Status.js | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 09185535..b5a3683a 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -750,3 +750,7 @@ table.osds td:first-of-type { .pmx-tag-tooltip .proxmox-tags-full > span { margin: 0px; } + +.pmx-column-wrapped > div { + white-space: pre-wrap; +} diff --git a/www/manager6/ceph/Status.js b/www/manager6/ceph/Status.js index ab882327..4845db99 100644 --- a/www/manager6/ceph/Status.js +++ b/www/manager6/ceph/Status.js @@ -82,6 +82,16 @@ Ext.define('PVE.node.CephStatus', { stateId: 'ceph-status-warnings', viewConfig: { enableTextSelection: true, + listeners: { + collapsebody: function(rowNode, record) { + record.set('expanded', false); + record.commit(); + }, + expandbody: function(rowNode, record) { + record.set('expanded', true); + record.commit(); + }, + }, }, // we load the store manually, to show an emptyText specify an empty intermediate store store: { @@ -139,6 +149,12 @@ Ext.define('PVE.node.CephStatus', { { dataIndex: 'summary', header: gettext('Summary'), + renderer: function(value, metaData,record, rI, cI, store, view) { + if (record.get('expanded')) { + metaData.tdCls = 'pmx-column-wrapped'; + } + return value; + }, flex: 1, }, { -- 2.30.2