From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 41164B8C39 for ; Wed, 6 Dec 2023 12:35:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 21DCE637 for ; Wed, 6 Dec 2023 12:35:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 12:35:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 63E8D41042 for ; Wed, 6 Dec 2023 12:35:12 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 6 Dec 2023 12:34:49 +0100 Message-ID: <20231206113456.411898-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 0/6] switch low-level installer protocol to json X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 11:35:43 -0000 This switches the stdio-protocol for the low-level installer from simple, line-based messages to JSON. This solves a number of problems, most prominently that messages can now contain multiline text (or for that matter, any kind of data), as JSON handles that transparently. The actual "meaty" changes are in #3, the others are either some simple cleanups or test infra. I have also included a testsuite for both the Perl side of things, as well as the TUI, to ensure that it works and cannot be accidently broken easily in the future. Tested this by installing of PVE and PBS. Christoph Heiss (6): low-level: align wording of finish message ui: stdio: log error if display_html() is called on stdio backend tui, ui: switch over to JSON-based protocol test: add tests for UI^2 stdio protocol buildsys: setup proper test environment for testsuite tui: install progress: add tests for UI^2 stdio protocol Makefile | 9 +- Proxmox/UI/StdIO.pm | 43 ++-- proxmox-low-level-installer | 2 +- .../src/views/install_progress.rs | 195 +++++++++++++----- test/Makefile | 6 +- test/ui2-stdio.pl | 96 +++++++++ 6 files changed, 280 insertions(+), 71 deletions(-) create mode 100755 test/ui2-stdio.pl -- 2.42.0