From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FE09B892D for ; Tue, 5 Dec 2023 16:45:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5167E1DAA3 for ; Tue, 5 Dec 2023 16:45:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Dec 2023 16:45:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6B6D34286E for ; Tue, 5 Dec 2023 16:45:03 +0100 (CET) From: Max Carrara To: pve-devel@lists.proxmox.com Date: Tue, 5 Dec 2023 16:44:56 +0100 Message-Id: <20231205154458.268660-1-m.carrara@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC proxmox-widget-toolkit, pve-manager 0/2] Copy Button For Wizard Disk Configuration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2023 15:45:04 -0000 When creating a VM for testing purposes, e.g. a VM that's supposed to have 8 disks to test something in regards to ZFS, it's necessary to manually edit the configuration and repeatedly click on all desired options by hand - for every single disk. I always wished there was a copy button, so I decided to just implement it myself. These two patches are sent as RFC because I'm not 100% sure about the some of the naming, approaches and UI design decisions I have made, so it would be nice to get some feedback on that. In particular: - Maybe it's better to name the button "duplicate" instead of "copy"? * But that means it doesn't fit in the same row as the "add" button - Put the copy button next to the little icon for the delete button instead, displaying it for each list item? Max Carrara (1): input panel: add `raw` parameter to function `getValues` src/panel/InputPanel.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) Max Carrara (1): multi disk edit: add copy button www/manager6/panel/MultiDiskEdit.js | 78 +++++++++++++++++++++++++---- 1 file changed, 68 insertions(+), 10 deletions(-) -- 2.39.2