From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EFF699E37C for ; Mon, 27 Nov 2023 12:40:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D873F6704 for ; Mon, 27 Nov 2023 12:40:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 27 Nov 2023 12:40:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BFCC344C0A for ; Mon, 27 Nov 2023 12:40:19 +0100 (CET) From: Philipp Hufnagl To: pve-devel@lists.proxmox.com Date: Mon, 27 Nov 2023 12:39:57 +0100 Message-Id: <20231127114001.189590-1-p.hufnagl@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pbsplugin.pm, config.pm] Subject: [pve-devel] [PATCH storage v4 0/4] pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2023 11:40:21 -0000 This adds a check if the datastore and the namespace is valid when a user attempts to add a new PBS datastore. Since the namespace only can be checked after the datastore is validated, the datastore will be checked as well, regardless that it will be done later in the superclass anyway. The functionallity to check namespaces is added with this commit. For checking the datastore, existing code that has previously been refactored will be reused Since the server address has was not included on for the on_update_hook, I had to slightly modify src/PVE/API2/Storage/Config.pm. I checked and are pretty sure that this modification does not break anything, however a second look would be appreciated! Signed-off-by: Philipp Hufnagl --- Changes since v3: * Modify src/PVE/API2/Storage/Config.pm to add server address Changes since v2: * Typos * reuse connecton on one more place previously fortotten * simplify syntax Changes since v1: * do not add any overhead to activate_storage calls * splits code from activate_storage so parts of it can be reused * adds new methods to check namespaces * calls checks on add/update hooks Philipp Hufnagl (4): pbs: Move pbs_api_connect earlyer in the code pbs: Make it possible to reuse PBS connection for datastore API call pbs: Extraxt check_datastore_exists from activate_storage pbs: fix #5008: Check if datastore and namespace is valid on add- and update hooks src/PVE/API2/Storage/Config.pm | 4 +- src/PVE/Storage/PBSPlugin.pm | 122 +++++++++++++++++++++++---------- 2 files changed, 86 insertions(+), 40 deletions(-) -- 2.39.2