From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A1589D173 for ; Thu, 23 Nov 2023 13:37:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D819237019 for ; Thu, 23 Nov 2023 13:36:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Nov 2023 13:36:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8F34342BF4 for ; Thu, 23 Nov 2023 13:36:53 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 23 Nov 2023 13:36:52 +0100 Message-Id: <20231123123652.2173444-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: iso selector: correctly disable itself X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2023 12:37:25 -0000 we overwrote the 'setDisabled' method to disable the child elements, but forgot to give the arguments to callParent, which means it never disabled the IsoSelector. This fixes an issue where when disabling the virtio iso selector in the wizard again, the wizard would get invalid data from it. Signed-off-by: Dominik Csapak --- www/manager6/form/IsoSelector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/form/IsoSelector.js b/www/manager6/form/IsoSelector.js index 0bc6346c..408c1fa3 100644 --- a/www/manager6/form/IsoSelector.js +++ b/www/manager6/form/IsoSelector.js @@ -61,7 +61,7 @@ Ext.define('PVE.form.IsoSelector', { let me = this; me.lookup('storage').setDisabled(disabled); me.lookup('file').setDisabled(disabled); - me.callParent(); + me.callParent(arguments); }, referenceHolder: true, -- 2.30.2