From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7ADBC9D061 for ; Thu, 23 Nov 2023 09:58:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D0B234543 for ; Thu, 23 Nov 2023 09:58:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Nov 2023 09:58:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9E4E742CA6 for ; Thu, 23 Nov 2023 09:58:00 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Thu, 23 Nov 2023 09:57:56 +0100 Message-Id: <20231123085756.41987-2-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123085756.41987-1-l.wagner@proxmox.com> References: <20231123085756.41987-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit 2/2] notification ui: display yellow warning triangle instead of red icon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Nov 2023 08:58:31 -0000 Instead of coloring the entire icon red, show a yellow warning triangle containing an exclamation mark in case of validation errors. Signed-off-by: Lukas Wagner --- src/window/NotificationMatcherEdit.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js index 5e81e40..f88576a 100644 --- a/src/window/NotificationMatcherEdit.js +++ b/src/window/NotificationMatcherEdit.js @@ -593,7 +593,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', { text = Ext.String.format(gettext("Match severity: {0}"), v); iconCls = 'fa fa-exclamation'; if (!v) { - iconCls += ' critical'; + iconCls += ' internal-error'; } } break; case 'match-field': { @@ -602,7 +602,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', { text = Ext.String.format(gettext("Match field: {0}={1}"), field, value); iconCls = 'fa fa-square-o'; if (!field || !value) { - iconCls += ' critical'; + iconCls += ' internal-error'; } } break; case 'match-calendar': { @@ -610,7 +610,7 @@ Ext.define('Proxmox.panel.NotificationMatchRuleTree', { text = Ext.String.format(gettext("Match calendar: {0}"), v); iconCls = 'fa fa-calendar-o'; if (!v || !v.length) { - iconCls += ' critical'; + iconCls += ' internal-error'; } } break; case 'mode': -- 2.39.2