From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3C57E9C555 for ; Wed, 22 Nov 2023 12:54:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D43617228 for ; Wed, 22 Nov 2023 12:53:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 22 Nov 2023 12:53:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1EAF2421AD; Wed, 22 Nov 2023 12:53:51 +0100 (CET) From: Wolfgang Bumiller To: pve-devel@lists.proxmox.com Date: Wed, 22 Nov 2023 12:53:43 +0100 Message-Id: <20231122115350.131255-1-w.bumiller@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnets.pm, zones.pm, dns.pm, controllers.pm, vnets.pm, simpleplugin.pm, ipams.pm] Subject: [pve-devel] applied-series: [PATCH network 0/7] PUT API endpoint changes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2023 11:54:23 -0000 This is a breaking API change for zones, vnets and subnets! These previously expected the *complete* config, which is not how our usual SectionConfigs work. Further, they advertised a 'delete' API parameter which was simply passed through as a config property which of course failed validation. Instead, they now merge the provided changes the way we normally do, and handle the 'delete' parameter. This affects: - /cluster/sdn/zones/ - /cluster/sdn/vnets/ - /cluster/sdn/vnets//subnets/ Additionally, these already took partial updates, but ignored the 'delete' parameter, which is fixed in this series: - /cluster/sdn/ipams/ - /cluster/sdn/dns/ - /cluster/sdn/controllers/ Wolfgang Bumiller (7): Revert "sdn: require ipam in simple plugin for dhcp" api: take partial configs for PUT /cluster/sdn/zones/ api: take partial configs for PUT /cluster/sdn/vnets/ api: take partial configs for PUT /cluster/sdn/vnets//subnets/ api: handle delete parameter when updating ipams api: handle delete parameter when updating dns entries api: handle delete parameter when updating controllers src/PVE/API2/Network/SDN/Controllers.pm | 7 +++++++ src/PVE/API2/Network/SDN/Dns.pm | 7 +++++++ src/PVE/API2/Network/SDN/Ipams.pm | 7 +++++++ src/PVE/API2/Network/SDN/Subnets.pm | 12 ++++++++++-- src/PVE/API2/Network/SDN/Vnets.pm | 24 +++++++++++++++++++---- src/PVE/API2/Network/SDN/Zones.pm | 18 ++++++++++++++--- src/PVE/Network/SDN/Zones/SimplePlugin.pm | 1 - 7 files changed, 66 insertions(+), 10 deletions(-) -- 2.39.2