From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 888059C225 for ; Tue, 21 Nov 2023 17:57:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 67E47DFA7 for ; Tue, 21 Nov 2023 17:57:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 17:57:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7AC8B41DB4 for ; Tue, 21 Nov 2023 17:57:12 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 17:56:58 +0100 Message-Id: <20231121165658.1563304-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH kernel-helper] grub-install: provide --removable to grub-install X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 16:57:13 -0000 noticed while installing with secure-boot enabled on ZFS RAID1: The system has no entry to boot from in the efi-vars and the entry for the first disk simply does not boot (I assume OVMF tries the default bootx64.efi. Since `proxmox-boot-tool init` should only be done for ESPs, which are dedicated to proxmox products I don't think that this will cause many regressions For comparison - our installer has done the manual equivalent of the --removable option for installs on ext4 for quite a while. minimally tested on a VM during install. Reported-by: Thomas Lamprecht Signed-off-by: Stoiko Ivanov --- ftr: In Mira's tests a RAID1 install on ZFS booted fine as long as both disks were added to the boot-options (which I cannot explain) src/bin/proxmox-boot-tool | 1 + 1 file changed, 1 insertion(+) diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool index befa2fb..e70850a 100755 --- a/src/bin/proxmox-boot-tool +++ b/src/bin/proxmox-boot-tool @@ -166,6 +166,7 @@ init_bootloader() { --target x86_64-efi \ --no-floppy \ --efi-directory "${esp_mp}" \ + --removable \ --bootloader-id 'proxmox' \ "/dev/$PKNAME" else -- 2.39.2