From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E057F9C0A9 for ; Tue, 21 Nov 2023 16:10:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48D44C707 for ; Tue, 21 Nov 2023 16:10:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 16:10:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0729941865 for ; Tue, 21 Nov 2023 16:10:27 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 16:10:25 +0100 Message-Id: <20231121151025.233224-8-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231121151025.233224-1-m.sandoval@proxmox.com> References: <20231121151025.233224-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v2 7/7] gui: remove trailing spaces and colons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 15:10:58 -0000 For consistency sake, all colons and trailing spaces in labels that were followed with an entry were removed, this matches other panels such as the password and country/timezone panels. Signed-off-by: Maximiliano Sandoval --- proxinstall | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/proxinstall b/proxinstall index 9551a89..015cf7b 100755 --- a/proxinstall +++ b/proxinstall @@ -416,7 +416,7 @@ sub create_ipconf_view { $device_cb->set_active(0); } - my $label = Gtk3::Label->new("Management Interface:"); + my $label = Gtk3::Label->new("Management Interface"); $label->set_size_request(150, -1); $label->set_xalign(1.0); @@ -428,7 +428,7 @@ sub create_ipconf_view { my $domain = $ipconf->{domain} || "example.invalid"; $fqdn //= "$hostname.$domain"; - my ($host_label, $hostentry) = create_text_input($fqdn, 'Hostname (FQDN):'); + my ($host_label, $hostentry) = create_text_input($fqdn, 'Hostname (FQDN)'); $grid->attach($host_label, 0, 1, 1, 1); $grid->attach($hostentry, 1, 1, 1, 1); @@ -438,14 +438,14 @@ sub create_ipconf_view { my $cfg_gateway = Proxmox::Install::Config::get_gateway(); my $gateway = $cfg_gateway // $ipconf->{gateway} || '192.168.100.1'; - my ($gw_label, $ipconf_entry_gw) = create_text_input($gateway, 'Gateway:'); + my ($gw_label, $ipconf_entry_gw) = create_text_input($gateway, 'Gateway'); $grid->attach($gw_label, 0, 3, 1, 1); $grid->attach($ipconf_entry_gw, 1, 3, 1, 1); my $cfg_dns = Proxmox::Install::Config::get_dns(); my $dnsserver = $cfg_dns // $ipconf->{dnsserver} || $gateway; - my ($dns_label, $ipconf_entry_dns) = create_text_input($dnsserver, 'DNS Server:'); + my ($dns_label, $ipconf_entry_dns) = create_text_input($dnsserver, 'DNS Server'); $grid->attach($dns_label, 0, 4, 1, 1); $grid->attach($ipconf_entry_dns, 1, 4, 1, 1); @@ -1332,7 +1332,7 @@ sub create_hdoption_view { $target_hd_label->set_text("Target: $filesys "); $options_stack->set_visible_child_name("raiddisk"); } else { - $target_hd_label->set_text("Target Harddisk: "); + $target_hd_label->set_text("Target Harddisk"); } if ($raid) { @@ -1438,7 +1438,7 @@ sub create_hdsel_view { Proxmox::Install::Config::set_target_hd($devname); } - $target_hd_label = Gtk3::Label->new("Target Harddisk: "); + $target_hd_label = Gtk3::Label->new("Target Harddisk"); $hbox->pack_start($target_hd_label, 0, 0, 0); $target_hd_combo = Gtk3::ComboBoxText->new(); -- 2.39.2