From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8890A9C09A for ; Tue, 21 Nov 2023 16:10:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68500C6CA for ; Tue, 21 Nov 2023 16:10:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 16:10:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 620CE418DD for ; Tue, 21 Nov 2023 16:10:26 +0100 (CET) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 16:10:21 +0100 Message-Id: <20231121151025.233224-4-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231121151025.233224-1-m.sandoval@proxmox.com> References: <20231121151025.233224-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v2 3/7] gui: use basic grid in password panel X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 15:10:57 -0000 The extra 10px margin on the email row was added to account for the removed line: $vbox->pack_start($hbox3, 0, 0, 15); Signed-off-by: Maximiliano Sandoval --- proxinstall | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/proxinstall b/proxinstall index a5de06c..69c48b4 100755 --- a/proxinstall +++ b/proxinstall @@ -688,47 +688,40 @@ sub create_password_view { my $password = Proxmox::Install::Config::get_password(); - my $vbox2 = Gtk3::Box->new('vertical', 0); - $gtk_state->{inbox}->pack_start($vbox2, 1, 0, 0); - my $vbox = Gtk3::Box->new('vertical', 0); - $vbox2->pack_start($vbox, 0, 0, 10); + my $grid = &$create_basic_grid(); + $gtk_state->{inbox}->pack_start($grid, 0, 0, 0); - my $hbox1 = Gtk3::Box->new('horizontal', 0); my $label = Gtk3::Label->new("Password"); $label->set_size_request(150, -1); $label->set_xalign(1.0); - $hbox1->pack_start($label, 0, 0, 10); + $grid->attach($label, 0, 0, 1, 1); my $pwe1 = Gtk3::Entry->new(); $pwe1->set_visibility(0); $pwe1->set_text($password) if $password; $pwe1->set_size_request(200, -1); - $hbox1->pack_start($pwe1, 0, 0, 0); + $grid->attach($pwe1, 1, 0, 1, 1); - my $hbox2 = Gtk3::Box->new('horizontal', 0); $label = Gtk3::Label->new("Confirm"); $label->set_size_request(150, -1); $label->set_xalign(1.0); - $hbox2->pack_start($label, 0, 0, 10); + $grid->attach($label, 0, 1, 1, 1); my $pwe2 = Gtk3::Entry->new(); $pwe2->set_visibility(0); $pwe2->set_text($password) if $password; $pwe2->set_size_request(200, -1); - $hbox2->pack_start($pwe2, 0, 0, 0); + $grid->attach($pwe2, 1, 1, 1, 1); - my $hbox3 = Gtk3::Box->new('horizontal', 0); $label = Gtk3::Label->new("Email"); $label->set_size_request(150, -1); $label->set_xalign(1.0); - $hbox3->pack_start($label, 0, 0, 10); + $label->set_margin_top(10); + $grid->attach($label, 0, 2, 1, 1); + my $eme = Gtk3::Entry->new(); $eme->set_size_request(200, -1); $eme->set_text(Proxmox::Install::Config::get_mailto()); - $hbox3->pack_start($eme, 0, 0, 0); - - - $vbox->pack_start($hbox1, 0, 0, 5); - $vbox->pack_start($hbox2, 0, 0, 5); - $vbox->pack_start($hbox3, 0, 0, 15); + $eme->set_margin_top(10); + $grid->attach($eme, 1, 2, 1, 1); $gtk_state->{inbox}->show_all; -- 2.39.2