From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7F9829BF4F for ; Tue, 21 Nov 2023 15:48:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 60C46BF19 for ; Tue, 21 Nov 2023 15:48:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 15:48:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4DCA8418A2 for ; Tue, 21 Nov 2023 15:48:02 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 15:47:58 +0100 Message-Id: <20231121144758.243333-5-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231121144758.243333-1-l.wagner@proxmox.com> References: <20231121144758.243333-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox-widget-toolkit 4/4] notification ui: add appropriate onlineHelp anchors X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 14:48:03 -0000 This links the dialog windows to the correct help section (different target types, matchers). Signed-off-by: Lukas Wagner --- src/panel/GotifyEditPanel.js | 1 + src/panel/NotificationConfigView.js | 1 + src/panel/SendmailEditPanel.js | 1 + src/panel/SmtpEditPanel.js | 1 + src/window/NotificationMatcherEdit.js | 1 + 5 files changed, 5 insertions(+) diff --git a/src/panel/GotifyEditPanel.js b/src/panel/GotifyEditPanel.js index 7e6ecd8..0e8cac4 100644 --- a/src/panel/GotifyEditPanel.js +++ b/src/panel/GotifyEditPanel.js @@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.GotifyEditPanel', { extend: 'Proxmox.panel.InputPanel', xtype: 'pmxGotifyEditPanel', mixins: ['Proxmox.Mixin.CBind'], + onlineHelp: 'notification_targets_gotify', type: 'gotify', diff --git a/src/panel/NotificationConfigView.js b/src/panel/NotificationConfigView.js index 4695da5..4d3ee46 100644 --- a/src/panel/NotificationConfigView.js +++ b/src/panel/NotificationConfigView.js @@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.NotificationConfigView', { extend: 'Ext.panel.Panel', alias: 'widget.pmxNotificationConfigView', mixins: ['Proxmox.Mixin.CBind'], + onlineHelp: 'chapter_notifications', layout: { type: 'border', }, diff --git a/src/panel/SendmailEditPanel.js b/src/panel/SendmailEditPanel.js index b744787..5a154c1 100644 --- a/src/panel/SendmailEditPanel.js +++ b/src/panel/SendmailEditPanel.js @@ -4,6 +4,7 @@ Ext.define('Proxmox.panel.SendmailEditPanel', { mixins: ['Proxmox.Mixin.CBind'], type: 'sendmail', + onlineHelp: 'notification_targets_sendmail', mailValidator: function() { let mailto_user = this.down(`[name=mailto-user]`); diff --git a/src/panel/SmtpEditPanel.js b/src/panel/SmtpEditPanel.js index 218485d..8b258e0 100644 --- a/src/panel/SmtpEditPanel.js +++ b/src/panel/SmtpEditPanel.js @@ -2,6 +2,7 @@ Ext.define('Proxmox.panel.SmtpEditPanel', { extend: 'Proxmox.panel.InputPanel', xtype: 'pmxSmtpEditPanel', mixins: ['Proxmox.Mixin.CBind'], + onlineHelp: 'notification_targets_smtp', type: 'smtp', diff --git a/src/window/NotificationMatcherEdit.js b/src/window/NotificationMatcherEdit.js index ee08c16..9ee34fd 100644 --- a/src/window/NotificationMatcherEdit.js +++ b/src/window/NotificationMatcherEdit.js @@ -73,6 +73,7 @@ Ext.define('Proxmox.window.NotificationMatcherEdit', { extend: 'Proxmox.window.Edit', isAdd: true, + onlineHelp: 'notification_matchers', fieldDefaults: { labelWidth: 120, -- 2.39.2