From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BA3FD9BA26 for ; Tue, 21 Nov 2023 12:10:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2372720C for ; Tue, 21 Nov 2023 12:10:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 12:10:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 96E1540F56 for ; Tue, 21 Nov 2023 12:10:13 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 12:09:58 +0100 Message-Id: <20231121110959.550051-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231121110959.550051-1-s.ivanov@proxmox.com> References: <20231121110959.550051-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.089 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 1/2] zfs: set canmount=off on /var/lib X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 11:10:44 -0000 as explained in zfsprops(4) setting canmount to off is similar to setting mountpoint to none - except that you can still use the dataset for storing properties to be inherited to children (and we want /var/lib/vz to have a mountpoint set) Follows recommendations from upstreams ZFS on / guide: https://openzfs.github.io/openzfs-docs/Getting%20Started/Debian/Debian%20Bookworm%20Root%20on%20ZFS.html Fixes: dd19d40ceac179ba18652f1d6c3e4c23f246af00 Signed-off-by: Stoiko Ivanov --- Proxmox/Install.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 1a4ee93..fd9bf84 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -189,6 +189,10 @@ sub zfs_create_rpool { syscmd("zfs create $pool_name/data") == 0 || die "unable to create zfs $pool_name/data volume\n"; syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz") == 0 || die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz volume\n"; + syscmd("zfs set canmount=off $pool_name/ROOT/$root_volume_name/var/lib") == 0 || + die "unable to set canmount property on $pool_name/ROOT/$root_volume_name/var/lib\n"; + syscmd("zfs set canmount=off $pool_name/ROOT/$root_volume_name/var") == 0 || + die "unable to set canmount property on $pool_name/ROOT/$root_volume_name/var\n"; } # default to `relatime` on, fast enough for the installer and production -- 2.39.2