From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E43849B988 for ; Tue, 21 Nov 2023 11:46:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C5A9E6AF6 for ; Tue, 21 Nov 2023 11:46:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 11:45:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 56F4540F54 for ; Tue, 21 Nov 2023 11:45:59 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 21 Nov 2023 11:45:51 +0100 Message-ID: <20231121104552.505851-5-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231121104552.505851-1-c.heiss@proxmox.com> References: <20231121104552.505851-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.250 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 4/4] common: enforce even number of disks for ZFS RAID-10 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 10:46:30 -0000 An uneven number of disks otherwise causes a panic due to an out-of-bounds array access in the loop below. Reported-by: Fiona Ebner Signed-off-by: Christoph Heiss --- proxmox-installer-common/src/disk_checks.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/proxmox-installer-common/src/disk_checks.rs b/proxmox-installer-common/src/disk_checks.rs index bcf2e21..7cbdf19 100644 --- a/proxmox-installer-common/src/disk_checks.rs +++ b/proxmox-installer-common/src/disk_checks.rs @@ -81,6 +81,14 @@ pub fn check_zfs_raid_config(level: ZfsRaidLevel, disks: &[Disk]) -> Result<(), } ZfsRaidLevel::Raid10 => { check_raid_min_disks(disks, 4)?; + + if disks.len() % 2 != 0 { + return Err(format!( + "Needs an even number of disks, currently selected: {}", + disks.len(), + )); + } + // Pairs need to have the same size for i in (0..disks.len()).step_by(2) { check_mirror_size(&disks[i], &disks[i + 1])?; -- 2.42.0