From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5797D9A152 for ; Fri, 17 Nov 2023 11:45:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39F491FEA7 for ; Fri, 17 Nov 2023 11:45:45 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Nov 2023 11:45:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4E17843D56 for ; Fri, 17 Nov 2023 11:45:44 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 17 Nov 2023 11:45:41 +0100 Message-Id: <20231117104541.49001-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH qemu] revert commit breaking VirtIO network adapters for certain versions of Windows X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2023 10:45:45 -0000 As reported in the community forum [0] and reproduced locally this breaks VirtIO network adapters in (at least) the German ISO of Windows Server 2022. The fix itself was for > Issue is not fatal but as result acpi-index/"PCI Label ID" property > is either not shown in device details page or shows incorrect value. so revert and tolerate that as a stop-gap, rather than have the devices not working at all. [0]: https://forum.proxmox.com/threads/92094/post-605684 Signed-off-by: Fiona Ebner --- ...workaround-Windows-not-handling-name.patch | 45 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 46 insertions(+) create mode 100644 debian/patches/extra/0008-Revert-x86-acpi-workaround-Windows-not-handling-name.patch diff --git a/debian/patches/extra/0008-Revert-x86-acpi-workaround-Windows-not-handling-name.patch b/debian/patches/extra/0008-Revert-x86-acpi-workaround-Windows-not-handling-name.patch new file mode 100644 index 0000000..02d9b6b --- /dev/null +++ b/debian/patches/extra/0008-Revert-x86-acpi-workaround-Windows-not-handling-name.patch @@ -0,0 +1,45 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Fiona Ebner +Date: Fri, 17 Nov 2023 11:18:06 +0100 +Subject: [PATCH] Revert "x86: acpi: workaround Windows not handling name + references in Package properly" + +This reverts commit 44d975ef340e2f21f236f9520c53e1b30d2213a4. + +As reported in the community forum [0] and reproduced locally this +breaks VirtIO network adapters in (at least) the German ISO of Windows +Server 2022. The fix itself was for + +> Issue is not fatal but as result acpi-index/"PCI Label ID" property +> is either not shown in device details page or shows incorrect value. + +so revert and tolerate that as a stop-gap, rather than have the +devices not working at all. + +[0]: https://forum.proxmox.com/threads/92094/post-605684 + +Signed-off-by: Fiona Ebner +--- + hw/i386/acpi-build.c | 8 ++------ + 1 file changed, 2 insertions(+), 6 deletions(-) + +diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c +index bb12b0ad43..de14d3c3da 100644 +--- a/hw/i386/acpi-build.c ++++ b/hw/i386/acpi-build.c +@@ -362,13 +362,9 @@ Aml *aml_pci_device_dsm(void) + { + Aml *params = aml_local(0); + Aml *pkg = aml_package(2); +- aml_append(pkg, aml_int(0)); +- aml_append(pkg, aml_int(0)); ++ aml_append(pkg, aml_name("BSEL")); ++ aml_append(pkg, aml_name("ASUN")); + aml_append(method, aml_store(pkg, params)); +- aml_append(method, +- aml_store(aml_name("BSEL"), aml_index(params, aml_int(0)))); +- aml_append(method, +- aml_store(aml_name("ASUN"), aml_index(params, aml_int(1)))); + aml_append(method, + aml_return(aml_call5("PDSM", aml_arg(0), aml_arg(1), + aml_arg(2), aml_arg(3), params)) diff --git a/debian/patches/series b/debian/patches/series index c27c245..ad84088 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -5,6 +5,7 @@ extra/0004-migration-block-dirty-bitmap-fix-loading-bitmap-when.patch extra/0005-hw-ide-reset-cancel-async-DMA-operation-before-reset.patch extra/0006-Revert-Revert-graph-lock-Disable-locking-for-now.patch extra/0007-migration-states-workaround-snapshot-performance-reg.patch +extra/0008-Revert-x86-acpi-workaround-Windows-not-handling-name.patch bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch bitmap-mirror/0002-drive-mirror-add-support-for-conditional-and-always-.patch bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch -- 2.39.2