From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2EFAB99CF4 for ; Thu, 16 Nov 2023 17:32:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BF2C17D9B for ; Thu, 16 Nov 2023 17:31:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Nov 2023 17:31:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 16C8843398 for ; Thu, 16 Nov 2023 17:31:48 +0100 (CET) Date: Thu, 16 Nov 2023 17:31:47 +0100 From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Message-ID: <20231116173147.5ac9e887@rosa.proxmox.com> In-Reply-To: <20231116150041.1089432-4-s.ivanov@proxmox.com> References: <20231116150041.1089432-1-s.ivanov@proxmox.com> <20231116150041.1089432-4-s.ivanov@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH installer 3/4] fix #1410: zfs: create /var/lib/vz as separate dataset X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2023 16:32:19 -0000 this is wrong! the dataset is only needed for pve I'll resend a v2 sorry for the noise! On Thu, 16 Nov 2023 16:00:40 +0100 Stoiko Ivanov wrote: > this enables the users to set reservations on / separate from > /var/lib/vz - where backups, ISOs, and other data might fill the > complete pool. > > Signed-off-by: Stoiko Ivanov > --- > Proxmox/Install.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm > index c868992..a96249e 100644 > --- a/Proxmox/Install.pm > +++ b/Proxmox/Install.pm > @@ -189,6 +189,9 @@ sub zfs_create_rpool { > syscmd("zfs create $pool_name/ROOT/$root_volume_name") == 0 || > die "unable to create zfs $pool_name/ROOT/$root_volume_name volume\n"; > > + syscmd("zfs create -p $pool_name/ROOT/$root_volume_name/var/lib/vz") == 0 || > + die "unable to create zfs $pool_name/ROOT/$root_volume_name/var/lib/vz volume\n"; > + > # default to `relatime` on, fast enough for the installer and production > syscmd("zfs set atime=on relatime=on $pool_name") == 0 || die "unable to set zfs properties\n"; >