From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A5C9198BC7 for ; Wed, 15 Nov 2023 16:59:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87C6DA048 for ; Wed, 15 Nov 2023 16:59:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 15 Nov 2023 16:59:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B90541E4F for ; Wed, 15 Nov 2023 16:59:25 +0100 (CET) From: Christian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 15 Nov 2023 16:59:10 +0100 Message-Id: <20231115155911.285968-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231115155911.285968-1-c.ebner@proxmox.com> References: <20231115155911.285968-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm, lxc.pm] Subject: [pve-devel] [PATCH pve-container 1/2] config: backup: add PBS change detection mode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Nov 2023 15:59:56 -0000 Adds the config option to switch from regular to metadata based change detection mode when using PBS as backend. Signed-off-by: Christian Ebner --- src/PVE/LXC/Config.pm | 7 +++++++ src/PVE/VZDump/LXC.pm | 5 +++++ 2 files changed, 12 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 56e1f10..687d3bf 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -612,6 +612,13 @@ my $confdesc = { description => "Try to be more verbose. For now this only enables debug log-level on start.", default => 0, }, + pbs_change_detection_mode => { + optional => 1, + type => 'string', + enum => ['data', 'metadata'], + description => "File change detection mode used for PBS backups.", + default => 'data', + }, }; my $valid_lxc_conf_keys = { diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm index c68a06f..d3aa57d 100644 --- a/src/PVE/VZDump/LXC.pm +++ b/src/PVE/VZDump/LXC.pm @@ -119,6 +119,8 @@ sub prepare { my $exclude_dirs = $task->{exclude_dirs} = []; $task->{hostname} = $conf->{'hostname'} || "CT$vmid"; + $task->{pbs_change_detection_mode} = $conf->{'pbs_change_detection_mode'} + if $conf->{'pbs_change_detection_mode'}; my ($id_map, $rootuid, $rootgid) = PVE::LXC::parse_id_maps($conf); $task->{userns_cmd} = PVE::LXC::userns_command($id_map); @@ -395,6 +397,9 @@ sub archive { push @$param, '--backup-id', $vmid; push @$param, '--backup-time', $task->{backup_time}; + push @$param, '--change-detection-mode', $task->{pbs_change_detection_mode} + if $task->{pbs_change_detection_mode}; + if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) { push $param->@*, '--entries-max', $entries_max; $self->loginfo( -- 2.39.2