From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 19A7799ED8 for ; Tue, 14 Nov 2023 15:02:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2A3C1C249 for ; Tue, 14 Nov 2023 15:02:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Nov 2023 15:02:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 582C7429A6 for ; Tue, 14 Nov 2023 15:02:07 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 14 Nov 2023 15:02:03 +0100 Message-Id: <20231114140204.27679-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231114140204.27679-1-f.ebner@proxmox.com> References: <20231114140204.27679-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Subject: [pve-devel] [RFC common 1/2] partially fix #4501: next unused port: bump port reservation expiretime X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2023 14:02:10 -0000 For QEMU migration via TCP, there's a bit of time between port reservation and usage, because currently, the port needs to be reserved before invoking a fork, where the systemd scope needs to be set up and swtpm might need to be started before the QEMU binary can be invoked and actually use the port. Not bumping too much, because mass migration with many small VMs might need to re-use the ports rather quickly (there's only 50 ports). The other two usages of the function are for VNC and SPICE, with 100 and 999 ports respectively. And for those, ports are usually used for longer than 30 seconds anyways, so the higher expire time should be fine. Signed-off-by: Fiona Ebner --- src/PVE/Tools.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index b3af2c6..4d018e9 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -918,7 +918,7 @@ sub next_unused_port { my $code = sub { - my $expiretime = 5; + my $expiretime = 30; my $ctime = time(); my $ports = {}; -- 2.39.2