From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4B824A0F11 for ; Fri, 10 Nov 2023 11:05:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D0EA1E215 for ; Fri, 10 Nov 2023 11:05:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 10 Nov 2023 11:05:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 72E89478CA for ; Fri, 10 Nov 2023 11:05:54 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 10 Nov 2023 11:05:53 +0100 Message-Id: <20231110100553.2426835-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: hide bulk migrate options on standalone nodes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2023 10:05:55 -0000 since there is nowhere to migrate to and we hide the regular migrate buttons/options too. Signed-off-by: Dominik Csapak --- www/manager6/node/CmdMenu.js | 5 +++++ www/manager6/node/Config.js | 2 ++ 2 files changed, 7 insertions(+) diff --git a/www/manager6/node/CmdMenu.js b/www/manager6/node/CmdMenu.js index dc56ef08..f5f9fae3 100644 --- a/www/manager6/node/CmdMenu.js +++ b/www/manager6/node/CmdMenu.js @@ -139,5 +139,10 @@ Ext.define('PVE.node.CmdMenu', { if (me.pveSelNode.data.running) { me.getComponent('wakeonlan').setDisabled(true); } + + let standalone = PVE.data.ResourceStore.getNodes().length < 2; + if (standalone) { + me.getComponent('bulkmigrate').setVisible(false); + } }, }); diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js index 6ed2172a..00a0e713 100644 --- a/www/manager6/node/Config.js +++ b/www/manager6/node/Config.js @@ -11,6 +11,7 @@ Ext.define('PVE.node.Config', { if (!nodename) { throw "no node name specified"; } + let standalone = PVE.data.ResourceStore.getNodes().length < 2; var caps = Ext.state.Manager.get('GuiCap'); @@ -69,6 +70,7 @@ Ext.define('PVE.node.Config', { text: gettext('Bulk Migrate'), iconCls: 'fa fa-fw fa-send-o', disabled: !caps.vms['VM.Migrate'], + hidden: standalone, handler: function() { Ext.create('PVE.window.BulkAction', { autoShow: true, -- 2.30.2