From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E2AFDA08AD for ; Thu, 9 Nov 2023 10:41:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CBF9612AB8 for ; Thu, 9 Nov 2023 10:41:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Nov 2023 10:41:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCB1E47584 for ; Thu, 9 Nov 2023 10:41:09 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 9 Nov 2023 10:40:55 +0100 Message-ID: <20231109094059.296544-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231109094059.296544-1-c.heiss@proxmox.com> References: <20231109094059.296544-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v3 1/2] tui: bootdisk: refactor Rc> type into custom type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2023 09:41:10 -0000 Will be used/passed around quite a lot of times due to future changes, so simplify it a bit. No functional changes. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs index 5272258..6309d74 100644 --- a/proxmox-tui-installer/src/views/bootdisk.rs +++ b/proxmox-tui-installer/src/views/bootdisk.rs @@ -29,9 +29,13 @@ use proxmox_installer_common::{ /// https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Module%20Parameters.html#zfs-arc-max const ZFS_ARC_MIN_SIZE_MIB: usize = 64; // MiB +/// Convience wrapper when needing to take a (interior-mutable) reference to `BootdiskOptions`. +/// Interior mutability is safe for this case, as it is completely single-threaded. +pub type BootdiskOptionsRef = Rc>; + pub struct BootdiskOptionsView { view: LinearLayout, - advanced_options: Rc>, + advanced_options: BootdiskOptionsRef, boot_type: BootType, } @@ -616,17 +620,17 @@ impl ViewWrapper for ZfsBootdiskOptionsView { fn advanced_options_view( runinfo: &RuntimeInfo, - options: Rc>, + options_ref: BootdiskOptionsRef, product_conf: ProductConfig, ) -> impl View { Dialog::around(AdvancedBootdiskOptionsView::new( runinfo, - &(*options).borrow(), + &(*options_ref).borrow(), product_conf, )) .title("Advanced bootdisk options") .button("Ok", { - let options_ref = options.clone(); + let options_ref = options_ref.clone(); move |siv| { let options = siv .call_on_name("advanced-bootdisk-options-dialog", |view: &mut Dialog| { -- 2.42.0