From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2992BA015D for ; Wed, 8 Nov 2023 07:55:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08C482A66 for ; Wed, 8 Nov 2023 07:55:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Nov 2023 07:55:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7F0FF472E2 for ; Wed, 8 Nov 2023 07:55:23 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Wed, 8 Nov 2023 07:55:17 +0100 Message-Id: <20231108065517.172917-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.067 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [accesscontrol.pm] Subject: [pve-devel] [PATCH access-control] acl: add missing SDN ACL paths to allowed list X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2023 06:55:25 -0000 else it's not actually possible to define ACLs on them, which means they are effectively root only instead of allowing their intended permission scheme. Signed-off-by: Fabian Grünbichler --- src/PVE/AccessControl.pm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index cc0f00b..9600e59 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1266,6 +1266,12 @@ sub check_path { |/pool |/pool/[[:alnum:]\.\-\_]+ |/sdn + |/sdn/controllers + |/sdn/controllers/[[:alnum:]\_\-]+ + |/sdn/dns + |/sdn/dns/[[:alnum:]]+ + |/sdn/ipams + |/sdn/ipams/[[:alnum:]]+ |/sdn/zones |/sdn/zones/[[:alnum:]\.\-\_]+ |/sdn/zones/[[:alnum:]\.\-\_]+/[[:alnum:]\.\-\_]+ -- 2.39.2