From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 330519FF54 for ; Tue, 7 Nov 2023 13:21:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 14BFA324D8 for ; Tue, 7 Nov 2023 13:21:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 7 Nov 2023 13:21:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B72DC469D4 for ; Tue, 7 Nov 2023 13:21:06 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 7 Nov 2023 13:20:50 +0100 Message-ID: <20231107122102.732841-3-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231107122102.732841-1-c.heiss@proxmox.com> References: <20231107122102.732841-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [install.pm] Subject: [pve-devel] [PATCH installer v4 2/6] install: use correct variable names in zfs_setup_module_conf() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2023 12:21:08 -0000 That's what happens when you do some last-minute variable renaming and trust that nothing broke .. Fixes: 42aa2fa ("fix #4829: install: add new ZFS `arc_max` setup option") Signed-off-by: Christoph Heiss --- Proxmox/Install.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 693ab15..c4b0700 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -296,8 +296,8 @@ sub get_zfs_raid_setup { my sub zfs_setup_module_conf { my ($targetdir) = @_; - my $arc_max = Proxmox::Install::Config::get_zfs_opt('arc_max'); - my $arc_max_mib = Proxmox::Install::RunEnv::clamp_zfs_arc_max($arc_max) * 1024 * 1024; + my $arc_max_mib = Proxmox::Install::Config::get_zfs_opt('arc_max'); + my $arc_max = Proxmox::Install::RunEnv::clamp_zfs_arc_max($arc_max_mib) * 1024 * 1024; if ($arc_max > 0) { file_write_all("$targetdir/etc/modprobe.d/zfs.conf", "options zfs zfs_arc_max=$arc_max\n") -- 2.42.0