From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 520D59FE32 for ; Tue, 7 Nov 2023 13:21:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A4263245E for ; Tue, 7 Nov 2023 13:21:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 7 Nov 2023 13:21:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D213A469C7 for ; Tue, 7 Nov 2023 13:21:06 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 7 Nov 2023 13:20:48 +0100 Message-ID: <20231107122102.732841-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, install.pm, bootdisk.rs, options.rs, proxmox.com, main.rs, setup.rs, zfs-arc-max.pl, runenv.pm] Subject: [pve-devel] [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2023 12:21:08 -0000 The installer `arc_max` option ZFS was introduced in [0], this exposes this option in the GUI/TUI installer for PVE installations. This can be adjusted when creating a ZFS RAID under "Advanced Options". The default value is choosen as 10% of system memory, clamped to between 64 MiB as lower limit and 16 GiB as upper limit. For PBS and PMG, the option is (currently) hidden. Tested by installing PVE, PBS and PMG, using both the GUI and TUI installer. For PVE, checked that the `zfs` module option gets correctly written & applied, the latter by looking at the output of `arc_summary`. For PBS and PMG, verified that no modprobe options file is created and the ARC size is set to default. [0] https://lists.proxmox.com/pipermail/pve-devel/2023-October/059731.html v1: https://lists.proxmox.com/pipermail/pve-devel/2023-August/058830.html v2: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059606.html v3: https://lists.proxmox.com/pipermail/pve-devel/2023-October/059731.html Notable changes v1 -> v2: * rebased on latest master * fix arc_max value set in TUI not being applied correctly Notable changes v2 -> v3: * rebased on latest master * new patch explaining query_total_memory, which is used extensively in this patchset * new patch unifying product handling a bit * documented all calculations better w.r.t. to their units * moved modprobe setup into separate sub Notable changes v3 -> v4: * rebased on latest master * dropped already applied patches from series * added new patch to drop debug print * added new patch fixing zfs_arc_max modprobe setting Christoph Heiss (6): run env: remove debug print install: use correct variable names in zfs_setup_module_conf() proxinstall: expose `arc_max` ZFS option for PVE installations test: add tests for zfs_arc_max calculations common: add ZFS `arc_max` installer setup option tui: bootdisk: expose `arc_max` ZFS option for PVE installations Makefile | 3 + Proxmox/Install.pm | 4 +- Proxmox/Install/RunEnv.pm | 1 - debian/control | 1 + proxinstall | 15 ++++ proxmox-installer-common/src/options.rs | 62 ++++++++++++++-- proxmox-installer-common/src/setup.rs | 2 + proxmox-tui-installer/src/main.rs | 2 +- proxmox-tui-installer/src/views/bootdisk.rs | 82 ++++++++++++++------- proxmox-tui-installer/src/views/mod.rs | 1 - test/Makefile | 10 +++ test/zfs-arc-max.pl | 81 ++++++++++++++++++++ 12 files changed, 228 insertions(+), 36 deletions(-) create mode 100644 test/Makefile create mode 100755 test/zfs-arc-max.pl -- 2.41.0