From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DACAD9FB08 for <pve-devel@lists.proxmox.com>; Tue, 7 Nov 2023 11:19:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 45DB2304A7 for <pve-devel@lists.proxmox.com>; Tue, 7 Nov 2023 11:19:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 7 Nov 2023 11:19:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E865846994 for <pve-devel@lists.proxmox.com>; Tue, 7 Nov 2023 11:19:05 +0100 (CET) From: Lukas Wagner <l.wagner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Tue, 7 Nov 2023 11:18:17 +0100 Message-Id: <20231107101827.340100-18-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231107101827.340100-1-l.wagner@proxmox.com> References: <20231107101827.340100-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.167 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH pve-manager 17/27] debian: postinst: create notifications.cfg if it does not exist X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 07 Nov 2023 10:19:42 -0000 We only warn on failure so that the postinst script does not fail in case pmxcfs is not running. Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> --- debian/postinst | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/debian/postinst b/debian/postinst index 4c9a1f25..7dad2b1a 100755 --- a/debian/postinst +++ b/debian/postinst @@ -93,6 +93,32 @@ migrate_apt_auth_conf() { fi } +write_notification_cfg() { + # Create default config: + # A sendmail-target that sends to root@pam, and a + # matcher that sends all notifications to this target + cat >> /etc/pve/notifications.cfg <<EOF +sendmail: default-target + mailto-user root@pam + comment Send mails to root@pam's email address + +matcher: default-matcher + target default-target + comment Send all notifications to 'default-target' +EOF +} + +create_default_notification_cfg() { + if ! test -f /etc/pve/notifications.cfg ; then + echo "Creating default 'notifications.cfg' file" + + # Only warn in case we cannot write to pmxcfs + if ! write_notification_cfg ; then + echo "Could not create default 'notifications.cfg' file" + fi + fi +} + case "$1" in triggered) # We don't print a status message here, as dpkg already said @@ -167,6 +193,8 @@ case "$1" in set_lvm_conf + create_default_notification_cfg + if test ! -e /proxmox_install_mode; then # modeled after code generated by dh_start for unit in ${UNITS}; do -- 2.39.2