From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E3C19E4BB for ; Tue, 31 Oct 2023 13:11:47 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B3191B054 for ; Tue, 31 Oct 2023 13:11:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 31 Oct 2023 13:11:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 17F4742BCA for ; Tue, 31 Oct 2023 13:11:16 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 31 Oct 2023 13:11:00 +0100 Message-ID: <20231031121108.1130299-9-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231031121108.1130299-1-c.heiss@proxmox.com> References: <20231031121108.1130299-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer v3 8/8] fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE installations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2023 12:11:47 -0000 To set the maximum value for arc_max accordingly, simply pass down `RuntimeInfo` directly instead of the disks array to the views. Signed-off-by: Christoph Heiss --- Changes v1 -> v2: * fix ZFS_ARC_MIN_SIZE to be MiB rather than bytes Changes v2 -> v3: * renamed `ZFS_ARC_MIN_SIZE` -> `ZFS_ARC_MIN_SIZE_MIB` and documented the origin of its value proxmox-tui-installer/src/main.rs | 2 +- proxmox-tui-installer/src/views/bootdisk.rs | 55 +++++++++++++++------ proxmox-tui-installer/src/views/mod.rs | 1 - 3 files changed, 42 insertions(+), 16 deletions(-) diff --git a/proxmox-tui-installer/src/main.rs b/proxmox-tui-installer/src/main.rs index 81fe3ca..5365d51 100644 --- a/proxmox-tui-installer/src/main.rs +++ b/proxmox-tui-installer/src/main.rs @@ -413,7 +413,7 @@ fn bootdisk_dialog(siv: &mut Cursive) -> InstallerView { InstallerView::new( &state, - BootdiskOptionsView::new(siv, &state.runtime_info.disks, &state.options.bootdisk) + BootdiskOptionsView::new(siv, &state.runtime_info, &state.options.bootdisk) .with_name("bootdisk-options"), Box::new(|siv| { let options = siv.call_on_name("bootdisk-options", BootdiskOptionsView::get_values); diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs index 07ca5b7..da4706b 100644 --- a/proxmox-tui-installer/src/views/bootdisk.rs +++ b/proxmox-tui-installer/src/views/bootdisk.rs @@ -20,6 +20,10 @@ use crate::{ }; use crate::{setup::ProxmoxProduct, InstallerState}; +/// OpenZFS specifies 64 MiB as the absolute minimum: +/// https://openzfs.github.io/openzfs-docs/Performance%20and%20Tuning/Module%20Parameters.html#zfs-arc-max +const ZFS_ARC_MIN_SIZE: usize = 64; // MiB + pub struct BootdiskOptionsView { view: LinearLayout, advanced_options: Rc>, @@ -27,13 +31,13 @@ pub struct BootdiskOptionsView { } impl BootdiskOptionsView { - pub fn new(siv: &mut Cursive, disks: &[Disk], options: &BootdiskOptions) -> Self { + pub fn new(siv: &mut Cursive, runinfo: &RuntimeInfo, options: &BootdiskOptions) -> Self { let bootdisk_form = FormView::new() .child( "Target harddisk", SelectView::new() .popup() - .with_all(disks.iter().map(|d| (d.to_string(), d.clone()))), + .with_all(runinfo.disks.iter().map(|d| (d.to_string(), d.clone()))), ) .with_name("bootdisk-options-target-disk"); @@ -47,11 +51,11 @@ impl BootdiskOptionsView { let advanced_button = LinearLayout::horizontal() .child(DummyView.full_width()) .child(Button::new("Advanced options", { - let disks = disks.to_owned(); + let runinfo = runinfo.clone(); let options = advanced_options.clone(); move |siv| { siv.add_layer(advanced_options_view( - &disks, + &runinfo, options.clone(), product_conf.clone(), )); @@ -104,7 +108,7 @@ struct AdvancedBootdiskOptionsView { } impl AdvancedBootdiskOptionsView { - fn new(disks: &[Disk], options: &BootdiskOptions, product_conf: ProductConfig) -> Self { + fn new(runinfo: &RuntimeInfo, options: &BootdiskOptions, product_conf: ProductConfig) -> Self { let filter_btrfs = |fstype: &&FsType| -> bool { product_conf.enable_btrfs || !fstype.is_btrfs() }; @@ -135,10 +139,10 @@ impl AdvancedBootdiskOptionsView { view.add_child(LvmBootdiskOptionsView::new(lvm, &product_conf)) } AdvancedBootdiskOptions::Zfs(zfs) => { - view.add_child(ZfsBootdiskOptionsView::new(disks, zfs)) + view.add_child(ZfsBootdiskOptionsView::new(runinfo, zfs, &product_conf)) } AdvancedBootdiskOptions::Btrfs(btrfs) => { - view.add_child(BtrfsBootdiskOptionsView::new(disks, btrfs)) + view.add_child(BtrfsBootdiskOptionsView::new(&runinfo.disks, btrfs)) } }; @@ -508,7 +512,13 @@ struct ZfsBootdiskOptionsView { impl ZfsBootdiskOptionsView { // TODO: Re-apply previous disk selection from `options` correctly - fn new(disks: &[Disk], options: &ZfsBootdiskOptions) -> Self { + fn new( + runinfo: &RuntimeInfo, + options: &ZfsBootdiskOptions, + product_conf: &ProductConfig, + ) -> Self { + let is_pve = product_conf.product == ProxmoxProduct::PVE; + let inner = FormView::new() .child("ashift", IntegerEditView::new().content(options.ashift)) .child( @@ -536,9 +546,16 @@ impl ZfsBootdiskOptionsView { ), ) .child("copies", IntegerEditView::new().content(options.copies)) + .child_conditional( + is_pve, + "ARC max size", + IntegerEditView::new_with_suffix("MiB") + .max_value(runinfo.total_memory) + .content(options.arc_max), + ) .child("hdsize", DiskSizeEditView::new().content(options.disk_size)); - let view = MultiDiskOptionsView::new(disks, &options.selected_disks, inner) + let view = MultiDiskOptionsView::new(&runinfo.disks, &options.selected_disks, inner) .top_panel(TextView::new( "ZFS is not compatible with hardware RAID controllers, for details see the documentation." ).center()); @@ -548,20 +565,30 @@ impl ZfsBootdiskOptionsView { fn new_with_defaults(runinfo: &RuntimeInfo, product_conf: &ProductConfig) -> Self { Self::new( - &runinfo.disks, + runinfo, &ZfsBootdiskOptions::defaults_from(runinfo, product_conf), + product_conf, ) } fn get_values(&mut self) -> Option<(Vec, ZfsBootdiskOptions)> { let (disks, selected_disks) = self.view.get_disks_and_selection()?; let view = self.view.inner_mut()?; + let has_arc_max = view.len() >= 6; + let disk_size_index = if has_arc_max { 5 } else { 4 }; let ashift = view.get_value::(0)?; let compress = view.get_value::, _>(1)?; let checksum = view.get_value::, _>(2)?; let copies = view.get_value::(3)?; - let disk_size = view.get_value::(4)?; + let disk_size = view.get_value::(disk_size_index)?; + + let arc_max = if has_arc_max { + view.get_value::(4)? + .max(ZFS_ARC_MIN_SIZE) + } else { + 0 // use built-in ZFS default value + }; Some(( disks, @@ -570,7 +597,7 @@ impl ZfsBootdiskOptionsView { compress, checksum, copies, - arc_max: 0, // use built-in ZFS default value + arc_max, disk_size, selected_disks, }, @@ -583,12 +610,12 @@ impl ViewWrapper for ZfsBootdiskOptionsView { } fn advanced_options_view( - disks: &[Disk], + runinfo: &RuntimeInfo, options: Rc>, product_conf: ProductConfig, ) -> impl View { Dialog::around(AdvancedBootdiskOptionsView::new( - disks, + runinfo, &(*options).borrow(), product_conf, )) diff --git a/proxmox-tui-installer/src/views/mod.rs b/proxmox-tui-installer/src/views/mod.rs index 8882ce9..e997968 100644 --- a/proxmox-tui-installer/src/views/mod.rs +++ b/proxmox-tui-installer/src/views/mod.rs @@ -43,7 +43,6 @@ impl NumericEditView { /// /// # Arguments /// * `suffix` - Content for the label to the right of it. - #[allow(unused)] pub fn new_with_suffix(suffix: &str) -> Self { let view = LinearLayout::horizontal() .child(EditView::new().content("0").full_width()) -- 2.42.0