From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 504259E0CC for ; Mon, 30 Oct 2023 13:58:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 337D4F198 for ; Mon, 30 Oct 2023 13:58:12 +0100 (CET) Received: from bookworm-dev.localdomain (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Mon, 30 Oct 2023 13:58:11 +0100 (CET) Received: by bookworm-dev.localdomain (Postfix, from userid 1000) id 91E9D60099; Mon, 30 Oct 2023 13:58:11 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 30 Oct 2023 13:58:11 +0100 Message-Id: <20231030125811.11759-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231030125811.11759-1-d.csapak@proxmox.com> References: <20231030125811.11759-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.385 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/2] ui: BulkAction: add clear filters button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2023 12:58:12 -0000 to be able to clear all of them at once Signed-off-by: Dominik Csapak --- sending this as a separate patch since i'm not sure if the button is worth it. if deemed appropriate could also be squashed into the previous patch www/manager6/window/BulkAction.js | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js index 333d5d30..44171390 100644 --- a/www/manager6/window/BulkAction.js +++ b/www/manager6/window/BulkAction.js @@ -162,6 +162,13 @@ Ext.define('PVE.window.BulkAction', { let tagList = Object.keys(tagMap).map(key => ({ value: key })); let haList = Object.keys(haMap).map(key => [key, key]); + let clearFilters = function() { + me.down('#namefilter').setValue(''); + ['name', 'status', 'pool', 'type', 'hastate', 'includetag', 'excludetag', 'vmid'].forEach((filter) => { + me.down(`#${filter}filter`).setValue(''); + }); + }; + let filterChange = function() { let nameValue = me.down('#namefilter').getValue(); let filterCount = 0; @@ -192,10 +199,13 @@ Ext.define('PVE.window.BulkAction', { } let fieldSet = me.down('#filters'); + let clearBtn = me.down('#clearBtn'); if (filterCount) { fieldSet.setTitle(Ext.String.format(gettext('Filters ({0})'), filterCount)); + clearBtn.setDisabled(false); } else { fieldSet.setTitle(gettext('Filters')); + clearBtn.setDisabled(true); } let filterFn = function(value) { @@ -383,6 +393,22 @@ Ext.define('PVE.window.BulkAction', { change: filterChange, }, }, + { + xtype: 'container', + layout: { + type: 'vbox', + align: 'end', + }, + items: [ + { + xtype: 'button', + itemId: 'clearBtn', + text: gettext('Clear Filters'), + disabled: true, + handler: clearFilters, + }, + ], + }, ], }, ], -- 2.39.2