From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15A5D9DA27 for ; Fri, 27 Oct 2023 13:30:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDFC138AF7 for ; Fri, 27 Oct 2023 13:30:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 27 Oct 2023 13:30:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3C86E42547; Fri, 27 Oct 2023 13:30:17 +0200 (CEST) From: Stefan Lendl To: pve-devel@lists.proxmox.com Date: Fri, 27 Oct 2023 13:29:59 +0200 Message-ID: <20231027113000.2008166-6-s.lendl@proxmox.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231027113000.2008166-1-s.lendl@proxmox.com> References: <87v8axbjh1.fsf@gmail.com> <20231027113000.2008166-1-s.lendl@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC qemu-server 5/6] do not remove DHCP mapping on VM stop X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2023 11:30:48 -0000 Signed-off-by: Stefan Lendl --- PVE/QemuServer.pm | 2 -- vm-network-scripts/pve-bridgedown | 4 ---- 2 files changed, 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6c1e463..710259b 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6143,8 +6143,6 @@ sub vm_stop_cleanup { cleanup_pci_devices($vmid, $conf); - cleanup_sdn_dhcp($vmid, $conf); - vmconfig_apply_pending($vmid, $conf, $storecfg) if $apply_pending_changes; }; warn $@ if $@; # avoid errors - just warn diff --git a/vm-network-scripts/pve-bridgedown b/vm-network-scripts/pve-bridgedown index a220660..8d58947 100755 --- a/vm-network-scripts/pve-bridgedown +++ b/vm-network-scripts/pve-bridgedown @@ -26,10 +26,6 @@ my $conf = PVE::QemuConfig->load_config($vmid); my $netconf = $conf->{$netid}; my $net = PVE::QemuServer::parse_net($netconf); -if ($have_sdn) { - PVE::Network::SDN::Dhcp::remove_mapping($net->{bridge}, $net->{macaddr}); -} - PVE::Network::tap_unplug($iface); exit 0; -- 2.41.0