From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BC8AB9D0D5 for ; Wed, 25 Oct 2023 11:09:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F2DC1237F for ; Wed, 25 Oct 2023 11:09:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 25 Oct 2023 11:09:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EF406450C7 for ; Wed, 25 Oct 2023 11:09:00 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 25 Oct 2023 11:08:59 +0200 Message-Id: <20231025090859.2235027-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.238 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve-xtermjs] xtermjs: try to detect hardware support for webgl2 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2023 09:09:02 -0000 with the new webgl renderer, chrome/chromium has buggy software support for emulating this (see [0]), so we have to detect that manually and prevent loading the addon. This fixes the issue that on chrome without hw support, it would not always render every character. Firefox does not have support for a software renderer and the loading/detection throws an exception, falling back to the default renderer. 0: https://github.com/xtermjs/xterm.js/issues/4574 Signed-off-by: Dominik Csapak --- tested with and without webgl hardware support on firefox/chrome/chromium xterm.js/src/main.js | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/xterm.js/src/main.js b/xterm.js/src/main.js index 85cc399..1575697 100644 --- a/xterm.js/src/main.js +++ b/xterm.js/src/main.js @@ -154,9 +154,15 @@ function createTerminal() { term = new Terminal(getTerminalSettings()); term.open(terminalContainer); term.loadAddon(fitAddon); + let loadedWebgl = false; try { - term.loadAddon(webglAddon); - } catch (_e) { + if (detectWebgl()) { + term.loadAddon(webglAddon); + loadedWebgl = true; + } + } catch (_e) { } + + if (!loadedWebgl) { console.warn("webgl-addon loading failed, falling back to regular dom renderer"); } @@ -384,3 +390,15 @@ function errorTerminal(event) { term.dispose(); updateState(states.disconnected, event.msg, event.code); } + +// try to detect hardware acceleration, can throw an exception if there is no webgl support +// +// for chrome we have to give the parameter, otherwise it'll use its software renderer +// which is buggy: https://github.com/xtermjs/xterm.js/issues/4574 +// +// firefox will fail on the getContext anyway if there is not hardware support +function detectWebgl() { + const canvas = document.createElement("canvas"); + const gl = canvas.getContext("webgl2", { failIfMajorPerformanceCaveat: true }); + return !!gl; +} -- 2.30.2