From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31EA19C652 for ; Tue, 24 Oct 2023 14:02:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1902C1FD64 for ; Tue, 24 Oct 2023 14:02:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 24 Oct 2023 14:02:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D1A8644B49 for ; Tue, 24 Oct 2023 14:02:18 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Date: Tue, 24 Oct 2023 14:02:12 +0200 Message-Id: <20231024120212.1860444-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit] text field: add trimValue config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2023 12:02:20 -0000 Inspired by a recent bug detected in the subscription key field, where a trailing white space caused verification issues. We might even enable the trimming by default, after checking call sites that is – most often one wants to trim the text to be submitted Signed-off-by: Thomas Lamprecht --- had that laying around since a while and figured why not, it's opt-in for now anyway. src/form/TextField.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/form/TextField.js b/src/form/TextField.js index 56e5976..7ee95c4 100644 --- a/src/form/TextField.js +++ b/src/form/TextField.js @@ -6,6 +6,8 @@ Ext.define('Proxmox.form.field.Textfield', { skipEmptyText: true, deleteEmpty: false, + + trimValue: false, }, getSubmitData: function() { @@ -29,6 +31,9 @@ Ext.define('Proxmox.form.field.Textfield', { let me = this; let value = this.processRawValue(this.getRawValue()); + if (me.getTrimValue() && typeof value === 'string') { + value = value.trim(); + } if (value !== '') { return value; } -- 2.39.2