From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EF56C9BADC for ; Fri, 20 Oct 2023 11:47:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C08E231FEC for ; Fri, 20 Oct 2023 11:46:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 20 Oct 2023 11:46:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F10CE435CC for ; Fri, 20 Oct 2023 11:46:55 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Fri, 20 Oct 2023 11:46:43 +0200 Message-ID: <20231020094651.432513-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [options.rs, setup.rs, runenv.pm, net.pm, utils.rs, ietf.org] Subject: [pve-devel] [PATCH installer 0/5] use hostname from DHCP lease if available X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2023 09:47:30 -0000 DHCP servers can set option 12 ("host-name") for client leases [0], telling them about their hostname. It's very much non-invasive and falls back to the default values as done currently. This came up while talking to Aaron, which he noticed (esp. during trainings) that this would be a very useful feature too have. I have tested this with the "host-name" entry set and unset, as well as any combinations of that with the domain name being set or unset. [0] https://datatracker.ietf.org/doc/html/rfc2132#section-3.14 Christoph Heiss (5): net: move hostname/fqdn regexes into common code run env: retrieve and store hostname from DHCP lease if available proxinstall: use hostname from run env if available tui: use hostname from run env if available tui: add some tests for `NetworkInfo` -> `NetworkOptions` conversion Proxmox/Install/RunEnv.pm | 4 + Proxmox/Sys/Net.pm | 28 ++++++ proxinstall | 15 +-- proxmox-tui-installer/src/options.rs | 132 +++++++++++++++++++++++++-- proxmox-tui-installer/src/setup.rs | 3 + proxmox-tui-installer/src/utils.rs | 2 +- 6 files changed, 169 insertions(+), 15 deletions(-) -- 2.42.0