From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EDF7A9B979 for ; Thu, 19 Oct 2023 15:36:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C49291A746 for ; Thu, 19 Oct 2023 15:36:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 19 Oct 2023 15:36:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB9CE430EA for ; Thu, 19 Oct 2023 15:36:07 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 19 Oct 2023 15:36:06 +0200 Message-Id: <20231019133607.1416999-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231019133607.1416999-1-d.csapak@proxmox.com> References: <20231019133607.1416999-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/3] ui: tags: prevent pasting non plain-text content X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2023 13:36:11 -0000 by setting 'contentEditable' to 'plaintext-only' instead of true. Otherwise it was possible to paste html code into the field (an error was thrown by the backend since it does not match the regex) Signed-off-by: Dominik Csapak --- www/manager6/form/Tag.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js index 6b1d6aa5..39afe04b 100644 --- a/www/manager6/form/Tag.js +++ b/www/manager6/form/Tag.js @@ -45,7 +45,7 @@ Ext.define('Proxmox.form.Tag', { selectText: function(collapseToEnd) { let me = this; let tagEl = me.tagEl(); - tagEl.contentEditable = true; + tagEl.contentEditable = "plaintext-only"; let range = document.createRange(); range.selectNodeContents(tagEl); if (collapseToEnd) { @@ -98,7 +98,7 @@ Ext.define('Proxmox.form.Tag', { let me = this; let tagEl = me.tagEl(); if (tagEl) { - tagEl.contentEditable = mode === 'editable'; + tagEl.contentEditable = mode === 'editable' ? 'plaintext-only' : false; } me.removeCls(me.mode); me.addCls(mode); -- 2.30.2