From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <m.frank@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 65D1F9A197 for <pve-devel@lists.proxmox.com>; Thu, 12 Oct 2023 12:02:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4684011F99 for <pve-devel@lists.proxmox.com>; Thu, 12 Oct 2023 12:02:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 12 Oct 2023 12:02:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C91748B08 for <pve-devel@lists.proxmox.com>; Thu, 12 Oct 2023 12:02:17 +0200 (CEST) From: Markus Frank <m.frank@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 12 Oct 2023 12:02:03 +0200 Message-Id: <20231012100207.83441-1-m.frank@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.296 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, machine.pm, qemuconfig.pm, qemu.pm, gnu.org] Subject: [pve-devel] [PATCH qemu-server/docs/manager v7 0/4] vIOMMU-Feature #3784 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 12 Oct 2023 10:02:19 -0000 I was able to clarify any ambiguity regarding vIOMMU: https://lists.gnu.org/archive/html/qemu-devel/2023-10/msg02370.html The iommu_platform parameter could be made an optional parameter for VirtIO devices to add more isolation (with the downside of making them less performant) in a follow-up patch series. qemu-server: v7: * changed viommu to string and added virtio-iommu implementation * seperated "machine as property-string" patch from "feature #3784" patch * moved format definition/parsing/printing to QemuServer::Machine * merged test-cases into "feature #3784" patch * removed kvm check, since it does not prevent vIOMMU from working (only nested virtualization requires kvm & host cpu) v6: * added helper function for machine config validation * replaced old standard option for "pve-qemu-machine" to new property string v5: * set $kvm to 1 if is_native, so that api kvm check works. v4: * added kvm/q35 checks in API * reused pve-qemu-machine v3: * replaced old machine type with property-string with viommu-parameter v2: * moved viommu-parameter inside of machine_fmt and added it the new parameter machine_properties new Config -> machine_properties: viommu=1,etc * check if kvm and q35 are set Markus Frank (2): machine as property-string feature #3784: Parameter for guest vIOMMU + test-cases PVE/API2/Qemu.pm | 11 ++++- PVE/QemuConfig.pm | 3 +- PVE/QemuServer.pm | 28 +++++++----- PVE/QemuServer/Machine.pm | 60 ++++++++++++++++++++++++- test/cfg2cmd/q35-viommu-intel.conf | 1 + test/cfg2cmd/q35-viommu-intel.conf.cmd | 23 ++++++++++ test/cfg2cmd/q35-viommu-virtio.conf | 1 + test/cfg2cmd/q35-viommu-virtio.conf.cmd | 23 ++++++++++ 8 files changed, 135 insertions(+), 15 deletions(-) create mode 100644 test/cfg2cmd/q35-viommu-intel.conf create mode 100644 test/cfg2cmd/q35-viommu-intel.conf.cmd create mode 100644 test/cfg2cmd/q35-viommu-virtio.conf create mode 100644 test/cfg2cmd/q35-viommu-virtio.conf.cmd docs: v7: * added virtio-iommu documentation * changed and seperated requirements v6: * changed capitalization and rephrased the text a bit. v5: * changed Host and VM Requirements Markus Frank (1): added vIOMMU documentation qm-pci-passthrough.adoc | 53 +++++++++++++++++++++++++++++++++++++++++ qm.adoc | 1 + 2 files changed, 54 insertions(+) manager: v7: * changed viommu checkbox to ComboBox to select either none, intel or VirtIO v6: * replaced '=== "1"' check with PVE.Parser.parseBoolean * replaced hidden kvm ui with view property * a few style changes v5: * added check if kvm is undefined or null v4: * check if kvm is enabled * added kvm+q35 hint Markus Frank (1): ui: MachineEdit with viommu ComboBox www/manager6/qemu/MachineEdit.js | 45 ++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) -- 2.39.2