From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C3CA98D01 for ; Tue, 10 Oct 2023 10:57:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 15C1D3017D for ; Tue, 10 Oct 2023 10:57:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Oct 2023 10:57:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2F0B64489A for ; Tue, 10 Oct 2023 10:57:07 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 10 Oct 2023 10:57:03 +0200 Message-Id: <20231010085703.27139-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server] qmeventd: also treat 'prelaunch' and 'suspended' states as active X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2023 08:57:08 -0000 Otherwise, a VM in those states would be terminated after a backup in handle_qmp_return() with QMP 'quit', which is pretty bad in case of the 'suspended' state. Does not change the fact that a VM started in prelaunch mode for backup is terminated later (that is handled by the Perl code). Signed-off-by: Fiona Ebner --- qmeventd/qmeventd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qmeventd/qmeventd.c b/qmeventd/qmeventd.c index 002b2ac4..d8f3ee72 100644 --- a/qmeventd/qmeventd.c +++ b/qmeventd/qmeventd.c @@ -272,8 +272,12 @@ handle_qmp_return(struct Client *client, struct json_object *data, bool error) bool active = false; if (has_status) { const char *status_str = json_object_get_string(status); - active = status_str && - (!strcmp(status_str, "running") || !strcmp(status_str, "paused")); + active = status_str && ( + !strcmp(status_str, "running") + || !strcmp(status_str, "paused") + || !strcmp(status_str, "suspended") + || !strcmp(status_str, "prelaunch") + ); } switch (client->state) { -- 2.39.2