From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DAECE92233 for ; Fri, 6 Oct 2023 13:02:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BFA9A329E7 for ; Fri, 6 Oct 2023 13:01:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 6 Oct 2023 13:01:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1590248F10 for ; Fri, 6 Oct 2023 13:01:52 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 6 Oct 2023 13:01:40 +0200 Message-Id: <20231006110148.154914-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231006110148.154914-1-f.ebner@proxmox.com> References: <20231006110148.154914-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.082 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 qemu 1/9] d/rules: use disable-download option instead of git-submodules=ignore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2023 11:02:22 -0000 See the following QEMU commits for reference: 0c5f3dcbb2 ("configure: add --enable-pypi and --disable-pypi") ac4ccac740 ("configure: rename --enable-pypi to --enable-download, control subprojects too") 6f3ae23b29 ("configure: remove --with-git-submodules=") removed The last one removed the option and the closest thing to git-submodule=ignore is using disable-download. Which will then just verify that the submodules are present. Building now will require running either * Running 'meson subprojects download' in the qemu submodule first. * Using --enable-download, but then the submodules would be downloaded for each build (if not already downloaded in the submodule first) and it's just a bit too surprising if downloads happen during build. The disable-download option will also disable automatic downloading of missing Python modules from PyPI. Hopefully, it's enough to add them as Debian build dependencies when required. Signed-off-by: Fiona Ebner --- No changes in v2. debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 4d06697..51f56c5 100755 --- a/debian/rules +++ b/debian/rules @@ -38,7 +38,7 @@ endif # guest-agent is only required for guest systems ./configure \ - --with-git-submodules=ignore \ + --disable-download \ --docdir=/usr/share/doc/pve-qemu-kvm \ --localstatedir=/var \ --prefix=/usr \ -- 2.39.2