From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <c.heiss@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 66BE791CAB for <pve-devel@lists.proxmox.com>; Wed, 4 Oct 2023 18:04:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47E13108D9 for <pve-devel@lists.proxmox.com>; Wed, 4 Oct 2023 18:03:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 4 Oct 2023 18:03:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E8A9C44888 for <pve-devel@lists.proxmox.com>; Wed, 4 Oct 2023 18:03:29 +0200 (CEST) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 4 Oct 2023 18:00:54 +0200 Message-ID: <20231004160325.704249-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 0/3] tui: remove global, unsafe setup info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 04 Oct 2023 16:04:01 -0000 Removes the `static mut` for holding a `SetupInfo` instance. This is done by either passing the needed info as parameter, or in some cases, the needed information is already available through other means. Not only does it get rid of some ugly, unsafe code, it is needed anyway as a prerequisite by Aaron for pulling out non-TUI-related code into a separate, shared crate. No functional changes overall. Christoph Heiss (3): tui: refactor `NetworkOptions` to have a `defaults_from()` function tui: bootdisk: pass down product info to advanced dialog tui: remove obsolete, global `SetupInfo` state proxmox-tui-installer/src/main.rs | 34 +++------- proxmox-tui-installer/src/options.rs | 36 ++++------ proxmox-tui-installer/src/setup.rs | 10 ++- proxmox-tui-installer/src/views/bootdisk.rs | 74 ++++++++++++++------- 4 files changed, 74 insertions(+), 80 deletions(-) -- 2.41.0