From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 69BE291B73 for ; Wed, 4 Oct 2023 16:43:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 37D3AF447 for ; Wed, 4 Oct 2023 16:42:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 4 Oct 2023 16:42:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 550EC44853 for ; Wed, 4 Oct 2023 16:42:41 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 4 Oct 2023 16:42:11 +0200 Message-ID: <20231004144232.327071-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH installer 0/7] tui: add min/max constraints for bootdisk parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2023 14:43:14 -0000 This adds minimum and maximum value constraints to the LVM, Btrfs and ZFS parameters in the bootdisk dialog. The current behaviour is to to either silently discard such values, which might yield unexpected results to users, or to throw some error later on during installation (due to e.g. failed ZFS pool creation), which does not indicate the exact cause. Both cases are really not desirable from a UX standpoint, especially with e.g. ZFS, where users might not know about the various constraints. The maximum value is clamped in such a way that the user cannot even enter a value bigger than allowed (which is the current behavior), but the same cannot be done for the minimum value. If the allowed range is 9 to 13, one could not enter e.g. `1` first, even if `12` was the desired value. Thus, the other approach is to simply validate on the dialog confirmation, passing down errors. The latter needed some (prep-)work to convert `Option` -> `Result`. Two new error enums were also introduced, to better represent errors that occured, rather than fiddeling around with strings. The TUI tests introduced in #7 show some techniques how components and their interactions can be properly tested. The same can be done for the GUI installer of course, but I didn't want to include in this series to avoid it being larger-than-necessary. series. Christoph Heiss (7): tui: fix setting content when using the `DiskSizeEditView` builder tui: improve `FormView` error handling tui: add optional min-value constraint to `NumericEditView` and `DiskSizeEditView` tui: add min/max constraints for ZFS bootdisk parameters tui: add min/max contraints for LVM bootdisk parameters tui: add min/max contraints for Btrfs bootdisk parameters tui: views: add some TUI component tests proxmox-tui-installer/src/main.rs | 51 ++- proxmox-tui-installer/src/options.rs | 2 +- proxmox-tui-installer/src/views/bootdisk.rs | 151 ++++--- proxmox-tui-installer/src/views/mod.rs | 421 ++++++++++++++++---- proxmox-tui-installer/src/views/timezone.rs | 115 +++++- 5 files changed, 608 insertions(+), 132 deletions(-) -- 2.41.0