From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B7DA8F406 for ; Fri, 29 Sep 2023 10:29:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A0AE51DDA8 for ; Fri, 29 Sep 2023 10:29:10 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 29 Sep 2023 10:29:08 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 4614E811F; Fri, 29 Sep 2023 10:29:01 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 385E559496; Fri, 29 Sep 2023 10:29:01 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Fri, 29 Sep 2023 10:28:59 +0200 Message-Id: <20230929082859.147270-3-aderumier@odiso.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230929082859.147270-1-aderumier@odiso.com> References: <20230929082859.147270-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.249 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH qemu-server 2/2] migration: add missing eval on nbdstop with tunnel v2. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2023 08:29:10 -0000 It was already done in tunnel v1. Avoid to avoid migration (and keep both source/targetvm locked) if nbdstop error occur 2023-09-28 16:20:39 ERROR: error - tunnel command '{"cmd":"nbdstop"}' failed - failed to handle 'nbdstop' command - VM 140 qmp command 'nbd-server-stop' failed - got timeout 2023-09-28 16:20:39 ERROR: migration finished with problems (duration 00:01:42) --- PVE/QemuMigrate.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index f41c61f..81880e5 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -1475,7 +1475,13 @@ sub phase3_cleanup { $self->log('info', "stopping NBD storage migration server on target."); # stop nbd server on remote vm - requirement for resume since 2.9 if ($tunnel && $tunnel->{version} && $tunnel->{version} >= 2) { - PVE::Tunnel::write_tunnel($tunnel, 30, 'nbdstop'); + eval { + PVE::Tunnel::write_tunnel($tunnel, 30, 'nbdstop'); + }; + if (my $err = $@) { + $self->log('err', $err); + $self->{errors} = 1; + } } else { my $cmd = [@{$self->{rem_ssh}}, 'qm', 'nbdstop', $vmid]; -- 2.39.2