From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E4BB7DCBB for ; Fri, 22 Sep 2023 11:25:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6C8187F5 for ; Fri, 22 Sep 2023 11:25:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 22 Sep 2023 11:25:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 19BE4487F1 for ; Fri, 22 Sep 2023 11:25:39 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Fri, 22 Sep 2023 11:25:25 +0200 Message-Id: <20230922092526.152176-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ceph.pm] Subject: [pve-devel] [PATCH manager v2 1/2] ceph: mark global pg bits setting as deprecated X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2023 09:25:40 -0000 This setting was removed in [1] as part of the v13.0.2 tag. Running ceph config set global osd_pg_bits 42 results in Error EINVAL: unrecognized config option 'osd_pg_bits' So we mark this api as deprecated and make it a no-op operation. [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc Signed-off-by: Maximiliano Sandoval --- Since this an API call, its hard for clients to get a warning thats logged on the server and I opted for just marking the API as deprecated in its description. Differences from v1: - Instead of removing the api, mark it as deprecated PVE/API2/Ceph.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 7e0763cf..fab4637c 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -158,10 +158,11 @@ __PACKAGE__->register_method ({ minimum => 1, maximum => 7, }, + # TODO: deprecrated, remove with PVE 9 pg_bits => { description => "Placement group bits, used to specify the " . - "default number of placement groups.\n\nNOTE: 'osd pool " . - "default pg num' does not work for default pools.", + "default number of placement groups.\n\nDepreacted. This " . + "setting was deprecated in recent Ceph versions.", type => 'integer', default => 6, optional => 1, @@ -224,11 +225,6 @@ __PACKAGE__->register_method ({ $cfg->{client}->{keyring} = '/etc/pve/priv/$cluster.$name.keyring'; } - if ($param->{pg_bits}) { - $cfg->{global}->{'osd pg bits'} = $param->{pg_bits}; - $cfg->{global}->{'osd pgp bits'} = $param->{pg_bits}; - } - if ($param->{network}) { $cfg->{global}->{'public network'} = $param->{network}; $cfg->{global}->{'cluster network'} = $param->{network}; -- 2.39.2