From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B8CCFD63A for ; Thu, 21 Sep 2023 13:23:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9B5251EDAF for ; Thu, 21 Sep 2023 13:23:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 21 Sep 2023 13:23:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D5F3E48662 for ; Thu, 21 Sep 2023 13:23:01 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 21 Sep 2023 13:22:56 +0200 Message-ID: <20230921112259.600582-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [block.pm] Subject: [pve-devel] [PATCH installer] sys: block: fix inverted check when detecting block size X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2023 11:23:02 -0000 We do actually want the block size if it is integer - currently, it is always set to `undef` (and then `null` in the serialized JSON). Fixes: 15b2cd7 ("sys: block: fix possible use of `undef`-value when detecting disk sizes") Signed-off-by: Christoph Heiss --- Proxmox/Sys/Block.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Sys/Block.pm b/Proxmox/Sys/Block.pm index f76e0f1..7593495 100644 --- a/Proxmox/Sys/Block.pm +++ b/Proxmox/Sys/Block.pm @@ -104,7 +104,7 @@ my sub hd_list { my $logical_bsize = file_read_firstline("$bd/queue/logical_block_size") // ''; chomp $logical_bsize; - if ($logical_bsize && $logical_bsize !~ m/^\d+$/) { + if ($logical_bsize && $logical_bsize =~ m/^\d+$/) { $logical_bsize = int($logical_bsize); } else { $logical_bsize = undef; -- 2.41.0